chore: Prepare for Java 14 #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
added
Topic: CI/CD
According to https://www.oracle.com/technetwork/java/13-relnote-issues-5460548.html#JDK-8218875 the `null` parameter should be cast to `Classloader` to solve this.
skaldarnar
requested review from
jdrueckert and
keturn
and removed request for
jdrueckert
keturn
reviewed
May 6, 2020
| @@ -94,7 +95,7 @@ public static boolean extractZipTo(final Path archive, final Path outputLocation | |||
| if (Files.notExists(outputLocation)) { | |||
| Files.createDirectories(outputLocation); | |||
| } | |||
| try (FileSystem fileSystem = FileSystems.newFileSystem(archive, null)) { | |||
| try (FileSystem fileSystem = FileSystems.newFileSystem(archive, ((ClassLoader) null))) { | |||
There was a problem hiding this comment.
This had me scratching my head for a minute before I checked the commit messages. Then that not only explained it but included a link to the relevant spot in the release notes. 👍
keturn
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Gradle to the latest release 6.3 with support for Java 14 and fixes a compile error.
In addition, switches the CI to use Java 14.
The launcher still builds and runs with Java 11 after this PR.