no longer checks for build receipt resource, skips Install and Download #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set off by a NPE warning and then kind of kept going.
also removes the need to check for that resource file that no longer exists after 2018.
It's no longer included in the current gradle distribution. Breaks support for issue MovingBlocks#2.
keturn
added a commit
to keturn/Terasology
that referenced
this pull request
May 18, 2020
makes groovy work with post-2018 gradle. MovingBlocks/groovy-wrapper#4
keturn
added a commit
to MovingBlocks/Terasology
that referenced
this pull request
May 19, 2020
makes groovy work with post-2018 gradle. MovingBlocks/groovy-wrapper#4
1 task
keturn
added a commit
to MovingBlocks/Terasology
that referenced
this pull request
May 23, 2020
makes groovy work with post-2018 gradle. MovingBlocks/groovy-wrapper#4
keturn
added a commit
to keturn/Terasology
that referenced
this pull request
May 24, 2020
makes groovy work with post-2018 gradle. MovingBlocks/groovy-wrapper#4
keturn
commented
May 28, 2020
Comment on lines
-60
to
-63
| WrapperExecutor wrapperExecutor = WrapperExecutor.forWrapperPropertiesFile(propertiesFile); | ||
| wrapperExecutor.execute( | ||
| args, | ||
| new Install(logger, new Download(logger, "gradlew", wrapperVersion()), new PathAssembler(gradleUserHome)), |
There was a problem hiding this comment.
I axed all this Install and Download invocation, but if you want to keep the download-and-install functionality, you leave this in and just replace that wrapperVersion() with org.gradle.wrapper.Download.UNKNOWN_VERSION: https://github.com/gradle/gradle/blob/00862b8160a09051e8226736314afd16e7f418f7/subprojects/wrapper/src/main/java/org/gradle/wrapper/Download.java#L24
aka "0"
keturn
commented
May 28, 2020
Comment on lines
+64
to
+65
| static File getAndVerifyDistributionRoot(File distDir) { | ||
| // Extracted from org.gradle.wrapper.Install.getAndVerifyDistributionRoot |
There was a problem hiding this comment.
and then if you keep that Install invocation, there's no reason to have this duplicate copy of this method brought over from the Install class.
Cervator
added a commit
that referenced
this pull request
May 31, 2020
Re-adds the ability to rely on an already downloaded Gradle via `gradlew` execution, on top of #4 for better convenience even if breaking backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will no longer update the gradle distribution when gradle.properties changes. But it also invokes less code to possibly break with gradle changes.
Fixes #3.
and breaks #2
That is, it no longer tries to put commons-io on the bootstrap classpath, because it's not in the current gradle distribution.