Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isEmpty to check whether the data is empty #2194

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

jolyot
Copy link
Contributor

@jolyot jolyot commented Sep 2, 2021

This PR is for the issue #2152

This is not a breaking API change, therefore I'm opening this PR towards the master branch.

Copy link
Contributor

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should point this to development instead of the main branch; we're planning to release a new version imminently, and to make sure everything can be merged as expected would be great.

Thanks! 😊

@BasThomas BasThomas changed the base branch from master to development September 2, 2021 08:19
@BasThomas BasThomas changed the base branch from development to master September 2, 2021 08:20
@jolyot jolyot changed the base branch from master to development September 2, 2021 09:45
Copy link
Contributor

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Copy link
Member

@OhKanghoon OhKanghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MoyaBot
Copy link

MoyaBot commented Sep 2, 2021

Warnings
⚠️

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

⚠️

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

⚠️

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.
⚠️

Any changes to library code should be reflected in the Changelog.
Please consider adding a note there and adhere to the Changelog Guidelines.

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L241 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L241 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L241 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L253 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L253 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L253 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L268 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L268 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

⚠️

Tests/MoyaTests/MoyaProviderSpec.swift#L268 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

Messages
📖 macOS: Executed 321 tests, with 0 failures (0 unexpected) in 16.840 (17.125) seconds
📖 tvOS: Executed 321 tests, with 0 failures (0 unexpected) in 14.159 (14.539) seconds
📖 iOS: Executed 321 tests, with 0 failures (0 unexpected) in 14.227 (14.583) seconds

Generated by 🚫 Danger Swift against cfcf882

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #2194 (cfcf882) into development (975110e) will increase coverage by 3.21%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2194      +/-   ##
===============================================
+ Coverage        88.78%   92.00%   +3.21%     
===============================================
  Files               30        5      -25     
  Lines              972       25     -947     
===============================================
- Hits               863       23     -840     
+ Misses             109        2     -107     
Impacted Files Coverage Δ
Sources/Moya/Atomic.swift 100.00% <0.00%> (ø)
Sources/Moya/Cancellable.swift 100.00% <0.00%> (ø)
Sources/ReactiveMoya/SignalProducer+Response.swift
Sources/Moya/MultiTarget.swift
Sources/Moya/Plugins/AccessTokenPlugin.swift
Sources/Moya/Plugin.swift
Sources/Moya/MoyaProvider+Defaults.swift
Sources/Moya/MoyaError.swift
Sources/Moya/Plugins/CredentialsPlugin.swift
Sources/CombineMoya/AnyPublisher+Response.swift
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84f8a2...cfcf882. Read the comment docs.

@BasThomas BasThomas merged commit 2330e68 into Moya:development Sep 2, 2021
@peril-moya
Copy link

peril-moya bot commented Sep 2, 2021

@jolyot Thanks a lot for contributing to Moya! We've invited you to join
the Moya GitHub organization – no pressure to accept! If you'd like more
information on what that means, check out our contributor guidelines and
feel free to reach out to @Moya/core-team with any questions.

Generated by 🚫 dangerJS

@jolyot jolyot deleted the check-data-empty branch September 2, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants