-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use isEmpty to check whether the data is empty #2194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should point this to development
instead of the main branch; we're planning to release a new version imminently, and to make sure everything can be merged as expected would be great.
Thanks! 😊
1fd98f7
to
cfcf882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Generated by 🚫 Danger Swift against cfcf882 |
Codecov Report
@@ Coverage Diff @@
## development #2194 +/- ##
===============================================
+ Coverage 88.78% 92.00% +3.21%
===============================================
Files 30 5 -25
Lines 972 25 -947
===============================================
- Hits 863 23 -840
+ Misses 109 2 -107 Continue to review full report at Codecov.
|
@jolyot Thanks a lot for contributing to Moya! We've invited you to join Generated by 🚫 dangerJS |
This PR is for the issue #2152
This is not a breaking API change, therefore I'm opening this PR towards the master branch.