Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Removed integ tests from Travis #133

Merged
merged 3 commits into from
Jul 30, 2018

Conversation

BScong
Copy link
Collaborator

@BScong BScong commented Jul 19, 2018

Fixes #132

Removed Integration tests from Travis. Please run them locally npm run integ-test, don't forget to set env vars. Updated Readme

Seems also that Pocket API now returns https instead of the http url for the integration tests. I fixed it, I hope it doesn't switch back to http.

@BScong BScong added this to In progress in Scout Jul 19, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.739%

Totals Coverage Status
Change from base Build 276: 0.0%
Covered Lines: 402
Relevant Lines: 716

💛 - Coveralls

@BScong BScong moved this from In progress to In Review in Scout Jul 19, 2018
Copy link
Contributor

@tamarahills tamarahills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the patch.

@BScong BScong merged commit 55054d2 into MozScout:master Jul 30, 2018
@BScong BScong deleted the 132_fix-integration-tests branch July 30, 2018 16:17
@BScong BScong moved this from In Review to Done in Scout Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Scout
  
Done
Development

Successfully merging this pull request may close these issues.

Remove integration tests from Travis
3 participants