Buyers Guide: QA product detail page

[kristinashu]

From ticket #1819 and doc.

Images

• hero image is broken (high priority)
• Related Product images are broken (high priority)

Categories Nav

• should be sticky (low priority)
• font weight 700 instead of 900 (low priority)
• font size from 17px to 15px (new update so that it fits better on all screen widths) (medium priority)
• Nav container should be consistent height (right now it changes depending if selected state bar is there or not) (low priority)

Grid

• grid is generally too narrow (update from 8 to 10 columns) (medium priority)

Intro

• copy link functionality isn't working in Safari on iPhone (medium priority)
• needs some sort of feedback so the user knows that the link has been copied [need to mock up] (medium priority)
• narrow layout: copy link should be moved lower down (medium priority)

Criteria

• need to add link to Privacy Policy (high priority)
• accordions work well but should style text in italics and 14px (medium priority)
• undetermined face has been updated from green to gray (low priority)
• grades should be individual and add "can't determine :|" (high priority)
• update password question and answer: "If a password is required, you must change the default password" Yes :) or No :( or Not required :| (high priority)
• add "Customer support" text above list of ways to contact them (medium priority)
• remove "Customer support" field from CMS (we don't show the answer) (high priority)
• medium layout: phone icon disappears (medium priority)
• medium layout for both 3 icons sections: list should stack and go into mobile view layout sooner (medium priority)
• narrow layout for both 3 icons sections: icon centering and spacing is off (medium priority)
• narrow layout: smile/frown faces shouldn't change size (medium priority)
• add Twitter as a contact (high priority) (this is a new feature, sorry)

[kristinashu]

We will be asking staff to help enter content on Oct 8 so we will need all the high priority notes done and live by then. So to avoid a Friday push I guess that means pushing it on Oct 4.

Does that sound ok @alanmoo @gvn?

[gvn]

That sounds do-able to me.

[gvn]

@alanmoo @cadecairos – Any idea why images would be working locally but not showing up in the staged PR?

[alanmoo]

This goes back to something I didn’t get to when setting up the scaffolding. There’s a media directory env var or something like that which needs to be added to the image URLs in the template. (Because on staging the images are on S3, but not locally)

[gvn]

@alanmoo Currently I have images set up like this, which works locally:

<img src="{{mediaUrl}}{{product.image}}" />

Do you know what I'd need to use instead?

[alanmoo]

Looks like you need to add {{AWS_LOCATION}} between the two, as uploaded images on staging are in the network directory (https://assets.mofostaging.net/network/images/buyersguide/nintendo-switch_1538423164.jpg for example).

@Pomax may be able to shed some more light on this for the proper way to do it.

[gvn]

Got it working. 🎉

[kristinashu]

👀

[kristinashu]

All the P1s are done so I'm going to close this and have open a new one for P2s:

• Buyers Guide: nav QA Buyers Guide: nav QA #1893
• Buyers Guide: QA product detail page P2

Closing!