PNI: Detail page WIP

[gvn]

No description provided.

[gvn]

https://foundation-mofostaging-pr-1846.herokuapp.com/privacynotincluded/

[kristinashu]

To move this ticket forward, I'm approving the design.

We have design QA notes are in this doc which I will put into a separate follow up ticket.

[gvn]

@alanmoo in the interest of keeping code reviews on the smaller side I think we should land this chunk. Have a look see and let me know if there are any glaring issues bearing in mind that it's very WIP.

[kristinashu]

I've put QA list in a ticket #1860

[alanmoo]

Some comments, please respond if you want separate tickets for them.

2 blockers to land this:

1. Fix Travis. I think it's just syntax.
2. Squash migrations

[alanmoo]

Not a blocker, but let's investigate putting the buyer's guide models into a folder in the sidebar so they're nicely contained when visible.

[alanmoo]

When picking an update, the select element simply shows "Update object". Let's get the title of the update to show up instead.

[gvn]

Do you happen to know how to do that?

[gvn]

NM got it

[alanmoo]

This also feels like a weird way to implement this. @gideonthomas do you happen to know of a DRYer, simple way to do this?

[gideonthomas]

Yeah don't create multiple FK properties on models. How you implement this depends on what the scenario here is:

A product can contain multiple updates, and multiple products can contain the same update:

class Product(models.Model):
    ...
    updates = models.ManyToManyField(Update, related_name='products', null=True)

A product can contain multiple updates, and an update is unique to (and belongs to) a single product (multiple products cannot have the same update):

class Update(models.Model):
    ...
    product = models.ForeignKey(Product, related_name='updates')

A product can contain multiple updates IN ORDER, and multiple products can contain the same update:
This is a little more work since you'll have to add logic to set the order everytime you add a new update to a product (using set_update_order() - docs)

class ProductUpdate(models.Model):
    product = models.ForeignKey(Product, on_delete=models.CASCADE)
    update = models.ForeignKey(Update, on_delete=models.CASCADE)

    class Meta:
        order_with_respect_to = 'product'
        unique_together = ('product', 'update',)
        # You will need to add this next property in a new migration after you migrate the rest of this model
        indexes = [
            models.Index(fields=['product', '_order'], name='uk_productupdate_productid_order'),
            models.Index(files=['product', 'update'], name='uk_productupdate_product_update')
        ]

A product can contain multiple updates IN ORDER, and an update is unique to (and belongs to) a single product (multiple products cannot have the same update):

class Update(models.Model):
    ...
    product = models.ForeignKey(Product, related_name='updates')
    
    class Meta:
        order_with_respect_to = 'product'
        # You will need to add this next property in a new migration after you migrate the rest of this model
        indexes = [
            models.Index(fields=['product', '_order'], name='uk_update_productid_order')
        ]