Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Image Text2 component #2693

Closed
7 tasks done
kristinashu opened this issue Feb 20, 2019 · 16 comments
Closed
7 tasks done

Updates to Image Text2 component #2693

kristinashu opened this issue Feb 20, 2019 · 16 comments
Assignees
Labels
backend frontend wagtail wagtail related issues

Comments

@kristinashu
Copy link

kristinashu commented Feb 20, 2019

This is probably blocked by - Remove deprecated components #1902 and Updates Figuregrid2 component #2696

Related to - New Image Text Mini component #2694

Based on design in #2282, component comps https://redpen.io/tuab5adf37d05d0414 and Fellowship comps https://redpen.io/p/mga45e3eeaaf9bc071.

Styling and CMS form fields

  • Keep image at 1:1 ratio
  • Add styles to Test so they match our style guide (H2-H6, normal body + large body, bold, italic, list, url link)
  • Add optional top divider and separate optional bottom divider (1px black)
  • Vertically center the image with the content
  • Mobile: halve the size of the image and left align it
  • Update component name from Image Text2 to Image Text [blocked by deprecating old component (Wagtail) Deprecated Image Text component needs to be removed from codebase #2739] - ok to hold off on name change
  • Remove Small checkbox (this is now Image text mini)

@alanmoo or @Pomax can you please either add to this ticket or open a separate one that includes additional steps for determining where this component is used and how we can make sure we don't break anything while doing these updates?

Component comp

image text 2x

@kristinashu kristinashu added wagtail wagtail related issues frontend labels Feb 20, 2019
@kristinashu kristinashu added this to Backlog in Foundation Site via automation Feb 20, 2019
@kristinashu kristinashu moved this from Backlog to Up Next in Foundation Site Feb 20, 2019
@Pomax Pomax added the backend label Feb 20, 2019
@Pomax
Copy link
Contributor

Pomax commented Feb 20, 2019

It looks like we're still using ImageTextBlock on nine pages so we'll have to switch those over to ImageTextBlock2 first before we can remove the original ImageTextBlock (which is a necessary step before we can start renaming things relating to ImageBlock2. Streamfield migrations are unfortunately even more complex than standard django model renames)

@kristinashu
Copy link
Author

Amazing that you can tell which pages are using it! I will update those tomorrow.

@kristinashu kristinashu self-assigned this Feb 20, 2019
@kristinashu
Copy link
Author

Ok that was painfully tedious but they're all gone now!

@kristinashu kristinashu removed their assignment Feb 21, 2019
@Pomax
Copy link
Contributor

Pomax commented Feb 22, 2019

Super! On a CMS permissions note, can you see the "settings -> block inventory" option? I don't recall it being an explicit permission in the user group policies, but I also don't think we ever checked that everyone with CMS access can see it, even though it'd be super useful if everyone could.

@kristinashu
Copy link
Author

Yes, I see it!

image

@Pomax
Copy link
Contributor

Pomax commented Feb 22, 2019

ah, perfect. Thanks for checking!

@kristinashu
Copy link
Author

I guess, feel free to do the renaming later if deleted the deprecated component is a blocker.

@alanmoo
Copy link
Contributor

alanmoo commented Feb 22, 2019

Removing the "small" checkbox is going to impact at least one page on the existing site: https://foundation.mozilla.org/en/initiatives/responsible-cs/challenge/.

Has an audit been done to understand the effects of this (and the URL removal)?

I wonder if it might be better to rebuild this as a separate component called Image Text and deprecate ImageText2

@kristinashu
Copy link
Author

ImageText2 (without the checkbox) has been used extensively on the site so replacing it would be a nightmare.

I can certainly do an audit of where the "small" checkbox has been used and then replace those with Image Text Mini when we have it (that's why I put mini as a higher priority to this one).

@youriwims
Copy link
Contributor

@kristinashu, any updates on the 'small' checkbox audit?

@youriwims youriwims self-assigned this Feb 25, 2019
@youriwims youriwims moved this from Up Next to In Progress in Foundation Site Feb 25, 2019
@youriwims
Copy link
Contributor

Add styles to Test so they match our style guide (H2-H6, normal body + large body, bold, italic, list, url link)

@kristinashu, what type of list(i.e. ordered/bulleted or unordered/no-bullets) did you want here?

@kristinashu
Copy link
Author

All those text styles should be the same as the Paragraph component.

@kristinashu kristinashu moved this from In Progress to In Review in Foundation Site Feb 27, 2019
youriwims pushed a commit that referenced this issue Feb 28, 2019
updated styles of imagetext2 component
@Pomax
Copy link
Contributor

Pomax commented Mar 6, 2019

marking as blocked until #2763 is on production (not just staging)

@Pomax
Copy link
Contributor

Pomax commented Mar 6, 2019

#2763 got deployed to production, marking as unblocked again.

@kristinashu
Copy link
Author

w00t Youri! Looks like this is all done and working great!

The final step is represented in - [Wagtail Component] Remove Image Text 2 Component #2793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend frontend wagtail wagtail related issues
Projects
No open projects
Development

No branches or pull requests

4 participants