Update donate buttons to new use link for foundation.mozilla.org #11998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdivincenzo
changed the title
danielfmiranda
requested changes
Mar 7, 2024
There was a problem hiding this comment.
Hi @robdivincenzo!
This is looking great, thanks for taking this on! 👍 I just have one small piece of feedback from the stakeholder:
Patrick asked if we could update the link at the bottom of the page in the footer, to ?form=donate-footer.
Once thats updated, this should be good to go!
Thanks again
|
Thanks @danielfmiranda ! Makes sense and the revision is made! |
danielfmiranda
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the header and footer on foundation.mozilla.org with a new donate URL supplied.
Link to sample test page: https://foundation-s-11909-upda-tt2ngu.herokuapp.com/en/
Related PRs/issues: #11909
To Test
Go to the homepage and inspect the donate button in the header and footer. The links should be set to /?form=donate-header and not /?form=donate