-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Half the gap by removing the spacing from the hidden header #7218
Half the gap by removing the spacing from the hidden header #7218
Conversation
This PR introduces visual differences. Click here to inspect the diffs. |
1 similar comment
This PR introduces visual differences. Click here to inspect the diffs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kalob! Thanks for tagging me in this and leaving easy to follow testing instructions.
I have taken a look at the page on mobile, and can confirm that the height is smaller than what it originally was.
I also took a look at the code, and everything looks good to me! Approving 👍
This PR introduces visual differences. Click here to inspect the diffs. |
This PR introduces visual differences. Click here to inspect the diffs. |
This PR introduces visual differences. Click here to inspect the diffs. |
Hey, sorry I didn't look at this sooner. I still see "no such app" at https://foundation-s-7110-halve-bn8dnw.herokuapp.com/en/campaigns/regrets-reporter/findings/ |
We need a working Review App for this. Moving to |
This PR introduces visual differences. Click here to inspect the diffs. |
@danielfmiranda do you need me to do anything on this? I still can't review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you Daniel!
This PR introduces visual differences. Click here to inspect the diffs. |
Closes #7110
Before:
After:
Link to sample test page: https://foundation-s-7110-halve-bn8dnw.herokuapp.com/en/campaigns/regrets-reporter/findings/
Steps to test: