Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half the gap by removing the spacing from the hidden header #7218

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

KalobTaulien
Copy link
Contributor

@KalobTaulien KalobTaulien commented Aug 11, 2021

Closes #7110

Before:

image

After:

image

Link to sample test page: https://foundation-s-7110-halve-bn8dnw.herokuapp.com/en/campaigns/regrets-reporter/findings/

Steps to test:

@mofodevops mofodevops temporarily deployed to foundation-s-7110-halve-bn8dnw August 11, 2021 17:50 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-7110-halve-bn8dnw August 11, 2021 17:52 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

1 similar comment
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-7110-halve-bn8dnw August 11, 2021 22:32 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kalob! Thanks for tagging me in this and leaving easy to follow testing instructions.

I have taken a look at the page on mobile, and can confirm that the height is smaller than what it originally was.

I also took a look at the code, and everything looks good to me! Approving 👍

@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-7110-halve-bn8dnw August 12, 2021 14:16 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-7110-halve-nxw26h August 18, 2021 16:42 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-7110-halve-6bpp21 August 18, 2021 16:42 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@kristinashu
Copy link

Hey, sorry I didn't look at this sooner. I still see "no such app" at https://foundation-s-7110-halve-bn8dnw.herokuapp.com/en/campaigns/regrets-reporter/findings/

@KalobTaulien
Copy link
Contributor Author

We need a working Review App for this. Moving to blocked until the review apps come back online for us.

@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@kristinashu
Copy link

@danielfmiranda do you need me to do anything on this? I still can't review it.

@mofodevops mofodevops temporarily deployed to foundation-s-7110-halve-1argxc October 14, 2021 17:58 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-7110-halve-bk14ca October 14, 2021 17:58 Inactive
Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you Daniel!

@danielfmiranda danielfmiranda merged commit aff743d into main Oct 14, 2021
@danielfmiranda danielfmiranda deleted the 7110-halve-the-yt-regrets-close-button-gap branch October 14, 2021 18:23
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[YouTube QA] Collapsed buttons need to be half the size
5 participants