Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize blog category title/share metadata #7461

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Conversation

TheoChevalier
Copy link
Contributor

Closes #7460

While that code is fresh in your mind, I’m improving the localization even further:

  • Localizing share metadata: seo title + description + image
  • Adding proper field for the page title instead of the concatenation with "Blog"

@mofodevops mofodevops temporarily deployed to foundation-s-blog-categ-ly76wv September 23, 2021 16:43 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@TheoChevalier TheoChevalier temporarily deployed to foundation-s-blog-categ-ly76wv September 23, 2021 17:05 Inactive
@TheoChevalier TheoChevalier temporarily deployed to foundation-s-blog-categ-ly76wv September 23, 2021 17:15 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

1 similar comment
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure there's always a page title =D

@TheoChevalier TheoChevalier temporarily deployed to foundation-s-blog-categ-ly76wv September 23, 2021 17:40 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@Pomax Pomax merged commit be519a9 into main Sep 23, 2021
@Pomax Pomax deleted the blog-categories-title branch September 23, 2021 17:57
stevedya pushed a commit that referenced this pull request Sep 27, 2021
* Blog category title localization

* CI

* Fixing CI harder

* review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom title to blog categories
3 participants