Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wagtail-localize crash when there’s a search description on PNI products #7525

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

TheoChevalier
Copy link
Contributor

Closes #7519

The field was duplicated, making wagtail-localize duplicate the translation, and crashing because of that.

Was able to confirm it fixes it for Signal with a copy of the staging db (hat tip to you)

@mofodevops mofodevops temporarily deployed to foundation-s-pni-search-bnqmbl September 29, 2021 14:37 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find, let's make sure we file this on the wagtail side as a bug, too, because that should definitely warn on startup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when syncing some PNI products
3 participants