Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7531 - BE Mozfest Hero Updates #7573

Merged
merged 12 commits into from
Oct 8, 2021
Merged

#7531 - BE Mozfest Hero Updates #7573

merged 12 commits into from
Oct 8, 2021

Conversation

SharmaineLim
Copy link
Contributor

@SharmaineLim SharmaineLim commented Oct 6, 2021

Closes #7531
Related PRs/issues #7432 (Epic)

Link to sample test page: (no staging site)

Implementation Checklist

  • Editor can add a heading
  • Editor can add a CTA label and link (Discussed with Jeth, the CTA will scroll down to the video)
  • Editor can specify 3 (no more, no less) subheadings each with their own heading, plain-text copy, and associated image
    • I kept the minimum number at zero so that the field isn't hard-required
  • Editor can specify an embedded YouTube video OR video in Wagtail

Of note

Checklist

Remove unnecessary checks

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?

Documentation:

  • Is my code documented?

Screenshots

Editor page up to body (with CMS-managed video)

image

Banner video chooser

image

Banner video from Youtube/Vimeo

image

@Pomax Pomax temporarily deployed to foundation-s-feature-be-ek97gb October 6, 2021 21:11 Inactive
Copy link
Collaborator

@b-ggs b-ggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Co-authored-by: boggs ⚓ <hello@boggs.xyz>
@mofodevops mofodevops temporarily deployed to foundation-s-feature-be-ek97gb October 7, 2021 06:17 Inactive
@b-ggs b-ggs changed the base branch from main to feature/fe-be-mozfest-hero-updates October 8, 2021 10:48
@b-ggs b-ggs merged commit 3aeafb3 into MozillaFoundation:feature/fe-be-mozfest-hero-updates Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BE: Mozfest Hero updates
4 participants