Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated cms to use UL and updated css to format it correctly on front end #7707

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Oct 27, 2021

Closes #7700
Related PRs/issues #7706

This PR holds the front end changes to make sure that the tips to protect yourself section renders correctly after adding the UL feature in the CMS in #7706.

Link to sample test page: https://foundation-s-updated-ti-yphytg.mofostaging.net/en/privacynotincluded/easy-seven-require-drive-unit-report/

Steps to test:

  1. Visit the test page linked above.
  2. Scroll down to the "Tips to protect yourself" section
  3. The section should be displaying as exected, with links/bold/italics.
  4. If the section looks as excpected, testing is complete!

@mofodevops mofodevops temporarily deployed to foundation-s-updated-ti-yphytg October 27, 2021 00:30 Inactive
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-updated-ti-yphytg October 27, 2021 00:46 Inactive
@danielfmiranda danielfmiranda changed the title updated cms to usse UL and updated css to format it correctly on front end updated cms to use UL and updated css to format it correctly on front end Oct 27, 2021
Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

image

@Pomax Pomax merged commit 7008316 into pni-q3-2021 Oct 27, 2021
@Pomax Pomax deleted the updated-tips-to-protect branch October 27, 2021 16:41
Pomax pushed a commit that referenced this pull request Nov 2, 2021
… end (#7707)

* updated cms to usse UL and updated css to format it correctly on front end

* updated whitespace

Co-authored-by: Daniel Miranda <daniel@mozillafoundation.org>
Pomax pushed a commit that referenced this pull request Nov 2, 2021
… end (#7707)

* updated cms to usse UL and updated css to format it correctly on front end

* updated whitespace

Co-authored-by: Daniel Miranda <daniel@mozillafoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants