Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Polish] UI localization issues for Settings #2344

Closed
Softvision-RemusDranca opened this issue Nov 21, 2019 · 1 comment · Fixed by #2680
Closed

[Polish] UI localization issues for Settings #2344

Softvision-RemusDranca opened this issue Nov 21, 2019 · 1 comment · Fixed by #2680
Assignees
@keianhzo
Labels
in progress L10n Localization [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#9 polish

Comments

@Softvision-RemusDranca
Copy link

[Polish] UI issues for Settings

[Affected Versions]:

  • Firefox Reality version 7-33242239 (98c54a4)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The Firefox Reality browser is opened.
  • The Polish language is set for the app.

[Steps to reproduce]:

  1. Click the "Settings" button from the tray menu
  2. Observe the "Developer Options" card.
  3. Click the "Display" card.
  4. Observe the "Homepage" and "Foveation Level" options.
  5. Open the "Manage Account" card and observe the "Reset" button.

[Expected results]:

  • The UI is correctly displayed.

[Actual results]:

  • Step 2: The card's name reaches the card's margins.
  • Step 4: The "Firefox Reality Home (Default) string is not entirely displayed.
  • Step 4: The "Foveation Level (App)" string overlaps with the first radio button.
  • Step 5: The "Reset" button name's is not fully visible.

[Notes]:

  • The "Reset" button is correctly displayed for the other menus in this language.
  • Attached are screen shots of the issues:
    • Developer Options card:
      PolishDeveloperOptions
    • Display card:
      PolishDisplay
    • Manage Account:
      org mozilla vrbrowser-20191121-181025
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label Nov 21, 2019
@jvonitter jvonitter added this to the #9 polish milestone Nov 21, 2019
@jvonitter jvonitter added the L10n Localization label Nov 21, 2019
Closed
@keianhzo keianhzo mentioned this issue Jan 20, 2020
Merged
bluemarvin pushed a commit that referenced this issue Jan 24, 2020
@keianhzo @bluemarvin
Fixes #2536 Fixes #2539 Fixes #2538 Fixes #2680 Fixes #2344 Fixes #1979…
992edc0 
… Settings adjustment for better L10n (#2680)

* Adjustments for the honeycomb buttons

* Make settings panels wider to better fit all languages
@heres-maria-sv-inactive
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 9-40240151 (7e03c94) build.
Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2).

@heres-maria-sv-inactive heres-maria-sv-inactive added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
in progress L10n Localization [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#9 polish
4 participants
@keianhzo @Softvision-RemusDranca @jvonitter @heres-maria-sv-inactive