Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L10n] The name of the "Sign Into Account" card from "Settings" has no padding #2538

Closed
Softvision-RemusDranca opened this issue Dec 23, 2019 · 2 comments · Fixed by #2680
Closed

[L10n] The name of the "Sign Into Account" card from "Settings" has no padding #2538

Softvision-RemusDranca opened this issue Dec 23, 2019 · 2 comments · Fixed by #2680
Assignees
@keianhzo
Labels
in progress L10n Localization [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#9 polish

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 8-33550026 (933fcd5)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the browser is opened.
  • The app's language is set in "Spanish".

[Steps to reproduce]:

  1. Click the Settings button.
  2. Observe the name of the "Sign Into Account" card.

[Expected results]:

  • The name is correctly displayed inside the card.

[Actual results]:

  • The name has no padding.

[Additional Notes]:

  • I was only able to encounter this issue with the "ES" and "FR" locales.
  • Attached is a screenshot of the issue:
    Untitled
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Minor issue Label for QA to mark minor issues logged label Dec 23, 2019
@jvonitter jvonitter added the L10n Localization label Jan 6, 2020
@jvonitter
Copy link
Contributor

related to #2539 and #2537

@jvonitter jvonitter added this to the #9 polish milestone Jan 8, 2020
@jvonitter jvonitter mentioned this issue Jan 8, 2020
Closed
@keianhzo keianhzo self-assigned this Jan 20, 2020
@keianhzo keianhzo mentioned this issue Jan 20, 2020
Merged
bluemarvin pushed a commit that referenced this issue Jan 24, 2020
@keianhzo @bluemarvin
Fixes #2536 Fixes #2539 Fixes #2538 Fixes #2680 Fixes #2344 Fixes #1979…
992edc0 
… Settings adjustment for better L10n (#2680)

* Adjustments for the honeycomb buttons

* Make settings panels wider to better fit all languages
@heres-maria-sv-inactive
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 9-40240151 (7e03c94) build. The card now has enough padding.
Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2).

@heres-maria-sv-inactive heres-maria-sv-inactive added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
in progress L10n Localization [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#9 polish
4 participants
@keianhzo @Softvision-RemusDranca @jvonitter @heres-maria-sv-inactive