Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Pop-up Blocked!" notification is displayed below the awesomebar #2759

Closed
heres-maria-sv-inactive opened this issue Feb 7, 2020 · 1 comment · Fixed by #2769
Closed

The "Pop-up Blocked!" notification is displayed below the awesomebar #2759

heres-maria-sv-inactive opened this issue Feb 7, 2020 · 1 comment · Fixed by #2769
Assignees
@keianhzo
Labels
in progress [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Milestone
#9 polish

Comments

@heres-maria-sv-inactive
Copy link

[Affected Versions]:

  • Firefox Reality version 9-40371914 (083b65c)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on, the browser is installed and open.

[Steps to reproduce]:

  1. Open a page that triggers pop-ups.
  2. Observe where the “Pop-up Blocked!” notification is displayed.

[Expected results]:

  • The notification is displayed above the awesomebar.

[Actual results]:

  • The notification is displayed below the awesomebar.

[Notes]:

  • The notification collides with the tooltip of the awesomebar button.
  • Attached is a screenshot of the issue:
    pop-up not
@heres-maria-sv-inactive heres-maria-sv-inactive added regression [QA]:Minor issue Label for QA to mark minor issues logged labels Feb 7, 2020
Open
@keianhzo keianhzo mentioned this issue Feb 10, 2020
Merged
@keianhzo keianhzo self-assigned this Feb 10, 2020
@keianhzo keianhzo added this to the #9 polish milestone Feb 10, 2020
bluemarvin pushed a commit that referenced this issue Feb 10, 2020
@keianhzo
Fixes #2760 Fixes #2759 Fixes #2762 Notification fixes (#2769)
3c90e7f 
* Fix Popup notification position

* Do not request focus for notifications

* Just hide the popup notification when it times-out
@heres-maria-sv-inactive
Copy link
Author

I have verified this issue and it is no longer reproducible with the latest Firefox Reality version 9-40412247 (3949e4c) build.
The notification is now displayed above the awesomebar.
Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2).

@heres-maria-sv-inactive heres-maria-sv-inactive added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
in progress [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Projects
None yet
Milestone
#9 polish
Development

Successfully merging a pull request may close this issue.

Fixes #2760 Fixes #2759 Fixes #2762 Notification fixes MozillaReality/FirefoxReality
2 participants
@keianhzo @heres-maria-sv-inactive