Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube video controls are not displayed correctly after resize to 1X or 0,5X in theater mode #2919

Closed
SoftVision-LorandJanos opened this issue Mar 4, 2020 · 2 comments · Fixed by #3394
Assignees
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues Youtube Youtube related issue
Milestone

Comments

@SoftVision-LorandJanos
Copy link

[Affected Versions]:

  • Firefox Reality version 9 rc7 (b68f946)

[Affected Platforms]:

  • HTC Vive Focus Plus - Android 7.1.2
  • Oculus Quest - Android 7.1.1
  • Pico Neo2 - Android 8.1.0

[Prerequisites]:

  • The Firefox Reality browser is opened.

[Steps to reproduce]:

  1. Navigate to a normal video on YouTube and enter theater/full screen mode.
  2. Resize the screen to 1x.
  3. Observe the video controls.
  4. Resize the screen to 0,5x.
  5. Observe the video controls.

[Expected results]:

  • The video controls are displayed correctly on the bottom of the screen.

[Actual results]:

  • The video controls are displayed partially after resizing to 1x
  • The video controls are not displayed after resizing to 0,5x.

[Notes]:

  • This issue is not reproducible with sizes greater than 1x.
  • If the video screen is scrolled down, the controls appear.
  • Attached is a video of this issue
@SoftVision-LorandJanos SoftVision-LorandJanos added the [QA]:Normal issue Label for QA to mark normal issues logged label Mar 4, 2020
@bluemarvin bluemarvin added this to the #10 features milestone Mar 9, 2020
@daoshengmu daoshengmu self-assigned this Mar 13, 2020
@daoshengmu
Copy link
Contributor

daoshengmu commented Mar 13, 2020

After digging into it a bit, the way we get window width and height makes sense to me. The problem is caused by Youtube UI. They will move down its UI when the canvas width is not wide enough. The workaround approach is restricting the targetHeight[1] must be larger than 2.35. Although we will see black color background at the border, the UI displays properly at least.

[1]

return Pair.create(targetWidth, targetHeight);

@bluemarvin bluemarvin added the Youtube Youtube related issue label Mar 18, 2020
@bluemarvin bluemarvin modified the milestones: #10 features, #11 polish Mar 18, 2020
@keianhzo keianhzo self-assigned this May 28, 2020
bluemarvin pushed a commit that referenced this issue May 28, 2020
* Hide Youtube overlays in immersive


Rebase fixes


wip

* Fix for the player chrome controls fast forwarding

* Use the parent container for chrome controls event handling

* Ensure player chrome controls are always visible in any resolution
@Softvision-GeluHaiduc
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 11-141492311 (a9b58ee) installed on the Oculus Go, Pico Neo2 and Pico G2 4K headsets.
Now, the YouTube video controls are displayed correctly after a resize to 1x or 0.5x in theater mode. There is a new behavior on videos longer than 1 hour where the controls are moved down on the 0.5x size window.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues Youtube Youtube related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants