-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2919 Fixes #2673 Fixes #2641 Hide Youtube fixes #3394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to break auto immersive 360 video.
STR:
- Click play on Mickey & Minnie's Runaway Railway
- Click on fullscreen icon
Actual results:
Video goes fullscreen
Expected results:
Video goes into immersive 360 mode.
This also doesn't seem to address #2673 as when I manually select a projection, it stays in that projection for the next video that is played. |
791a1e7
to
bfafa36
Compare
@bluemarvin I Don't seem to be able to reproduce the fullscreen issue with the provided STRs. Regarding:
AFAIK that's always been like that. We currently auto-select the projection based on a custom |
@keianhzo It has always been that way as far as I know. That's why I was not clear how this PR addresses #2673. If we don't plan to address it, we should close with a won't fix tag. I'll review again to see if I can reproduce the issue I was seeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any breakages but I'm not sure what this is fixing.
Rebase fixes wip
bfafa36
to
11c11b8
Compare
@bluemarvin I've updated I was missing a case and you were probably hitting it. I've also added a fix for a missing div in #2947 |
Fixes #2919 Fixes #2947 Fixes #2673 Hide YouTube overlays in immersive