Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ETP shield icon is wrongly displayed when opening unsupported files in the New Tab/Window #3281

Closed
Softvision-RemusDranca opened this issue Apr 29, 2020 · 1 comment · Fixed by #3287
Closed

The ETP shield icon is wrongly displayed when opening unsupported files in the New Tab/Window #3281

Softvision-RemusDranca opened this issue Apr 29, 2020 · 1 comment · Fixed by #3287
Assignees
@keianhzo
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Milestone
#10 features

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 10 RC3 (5b346b6).

[Affected Platforms]:

  • Pico Neo 2 - Android - 8.1.0
  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the app is opened.
  • Have an unsupported file downloaded ex: .zip.
  • The Permissions to access External Storage is disabled.

[Steps to reproduce]:

  1. Click the Downloads button from the tray.
  2. Hover over the unsupported file from prerequisites and click the 3 dot menu button.
  3. Click the "Open in a Tab" button.
  4. Observe if the ETP shield icon is displayed.

[Expected results]:

  • The icon is not displayed.

[Actual results]:

  • The icon is displayed.

[Notes]:

  • This issue is also reproducible when opening unsupported files in a New Window.
  • Attached is a screen recording of the issue: link.
@Softvision-RemusDranca Softvision-RemusDranca added regression [QA]:Normal issue Label for QA to mark normal issues logged labels Apr 29, 2020
Closed
@keianhzo keianhzo self-assigned this Apr 29, 2020
@keianhzo keianhzo added this to the #10 features milestone Apr 29, 2020
@keianhzo keianhzo mentioned this issue Apr 29, 2020
Merged
bluemarvin pushed a commit that referenced this issue Apr 29, 2020
@keianhzo
Fixes #3281 Fixes #3282 Only show URL buttons for http/https uris (#3287
18270f0 
)

* Only show URL buttons for http/https uris

* Also hide URL bar icons if in library
@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible with the Firefox Reality version 10 RC4 (2999129). The ETP shield icon is no longer displayed when opening unsupported files in a New Tab/Window.

Tested on HTC Vive Focus (Android 7.1.2), Oculus Quest (Android 7.1.1), and Pico Neo 2 (Android - 8.1.0) devices.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Projects
None yet
Milestone
#10 features
Development

Successfully merging a pull request may close this issue.

Fixes #3281 Fixes #3282 Only show URL buttons for http/https uris MozillaReality/FirefoxReality
2 participants
@keianhzo @Softvision-RemusDranca