Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

UI sounds are now too loud #751

Closed
cvan opened this issue Nov 13, 2018 · 3 comments
Closed

UI sounds are now too loud #751

cvan opened this issue Nov 13, 2018 · 3 comments
Assignees
@cvan
Labels
bug This issue is a software or functional defect P3 Backlog regression
Milestone
v1.1

Comments

@cvan
Copy link
Contributor

cvan commented Nov 13, 2018

Hardware

Oculus Go
1.0.1, eaa4fc5

Steps to Reproduce

  1. Exit Firefox Reality.
  2. Press the physical Volume-Up button until the volume is at the maximum level.
  3. Press the buttons in the browser chrome/UI.

Current Behavior

Notice the noises are too loud.

Expected Behavior

The noises should be ~70% quieter.
@cvan cvan added bug This issue is a software or functional defect P2 Fix in the next development iteration regression labels Nov 13, 2018
@cvan cvan changed the title Noises are now too loud Chrome/UI browser-level noises are now too loud Nov 13, 2018
@caseyyee caseyyee changed the title Chrome/UI browser-level noises are now too loud UI sounds are now too loud Nov 13, 2018
@caseyyee
Copy link
Contributor

Other sound inconsistencies found:

  • UI sounds do not play when using the hardware back button on controller.
  • Sounds not present with media controls.

UI sounds overall should be much more subtle/quite and it would be really nice to have the option to disable them altogether. Another idea would be to use haptics instead of sound to provide UI feedback.

@cvan cvan self-assigned this Nov 14, 2018
@cvan cvan added this to the v1.1 milestone Nov 20, 2018
@cvan
Copy link
Contributor Author

cvan commented Nov 21, 2018

I have a local branch of removing all logic for these audio files. To simplify things and reduce future tech debt, I will simply prevent the loading of the sounds but keep the listeners as they are. And we can polish the sounds and interactions in later releases. (Haptics would be nice, but there are no haptics in the Oculus Go controllers.)

cvan added a commit that referenced this issue Nov 22, 2018
@cvan
temporarily disable loud sounds for now (fixes issue #751)
b66f37d
keianhzo pushed a commit that referenced this issue Nov 24, 2018
@cvan @keianhzo
temporarily disable loud sounds for now (fixes issue #751)
79ecf2a
keianhzo added a commit that referenced this issue Nov 24, 2018
@keianhzo
temporarily disable loud sounds for now (fixes issue #751)
662d267
MortimerGoro pushed a commit that referenced this issue Nov 26, 2018
@cvan @MortimerGoro
temporarily disable loud sounds for now (fixes issue #751) (#813)
be7c603
@cvan
Copy link
Contributor Author

cvan commented Nov 26, 2018

done in PR #813 (merged)

@cvan cvan closed this as completed Nov 26, 2018
@cvan cvan added P3 Backlog and removed P2 Fix in the next development iteration labels Nov 27, 2018
This was referenced Mar 12, 2019
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cvan cvan

Labels
bug This issue is a software or functional defect P3 Backlog regression
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@cvan @caseyyee