Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarks broken on lenovo mirage & HTC Focus #911

Closed
larsbergstrom opened this issue Dec 31, 2018 · 3 comments
Closed

Bookmarks broken on lenovo mirage & HTC Focus #911

larsbergstrom opened this issue Dec 31, 2018 · 3 comments
Assignees
@MortimerGoro
Labels
bug This issue is a software or functional defect P1 Fix in the current development iteration
Milestone
v1.1.2

Comments

@larsbergstrom
Copy link

Hardware

Reproduced on HTC Focus; reported on Lenovo Mirage
Version 1.1.1 in-stores.

Steps to Reproduce

  1. Visit website
  2. Click Star to bookmark
  3. View bookmarks page

Current Behavior

No bookmark added

Expected Behavior

Bookmark added
@bluemarvin
Copy link
Contributor

Looks like #888 is the commit that broke it. I reverted it and was able to see the booksmarks page.

@cvan cvan added bug This issue is a software or functional defect P1 Fix in the current development iteration labels Jan 3, 2019
@cvan cvan modified the milestones: v1.2, v1.1.2 Jan 3, 2019
@cvan
Copy link
Contributor

cvan commented Jan 8, 2019 •
edited

@bluemarvin: @MortimerGoro: in your opinions, what would be the quickest and safest way to patch this?

@MortimerGoro MortimerGoro self-assigned this Jan 8, 2019
@MortimerGoro
Copy link
Contributor

I'm going to research this

MortimerGoro added a commit that referenced this issue Jan 8, 2019
@MortimerGoro
Fix broken WindowWidget views when not using layers. Fixes #911.
d2f8ab4
@MortimerGoro MortimerGoro mentioned this issue Jan 8, 2019
Merged
bluemarvin pushed a commit that referenced this issue Jan 8, 2019
@MortimerGoro @bluemarvin
Fix broken WindowWidget views when not using layers. Fixes #911. (#917)
5bfad39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MortimerGoro MortimerGoro

Labels
bug This issue is a software or functional defect P1 Fix in the current development iteration
Projects
None yet
Milestone
v1.1.2
Development

No branches or pull requests
4 participants
@bluemarvin @cvan @larsbergstrom @MortimerGoro