Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show the servo button for few websites #632

Merged
merged 1 commit into from Oct 23, 2018

Conversation

paulrouget
Copy link
Contributor

This is for after #498. We only want to show the button for some urls.
I moved the button to the right of the url bar to prevent the UI to "move" too much as the user navigates.

@jdm can you look at the list and tell me if there's anything else you want to add in there?

@paulrouget
Copy link
Contributor Author

Only check the last commit.

@MortimerGoro
Copy link
Contributor

Merging this in servobranch. We'll land the changes in servo branch to master after v1.1.

@MortimerGoro MortimerGoro merged commit 76bbc77 into MozillaReality:servo Oct 23, 2018
paulrouget added a commit to paulrouget/FirefoxReality that referenced this pull request Oct 25, 2018
paulrouget added a commit to paulrouget/FirefoxReality that referenced this pull request Jan 10, 2019
MortimerGoro pushed a commit that referenced this pull request Jan 18, 2019
* Only show servo button for few websites (#632)

* Make it obvious to which engine we're switching to (#659)

* Less naive engine switch mechanism (#674)

* Servo update

* GeckoView API udpate

* Servo version update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants