New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show the servo button for few websites #632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only check the last commit. |
paulrouget
force-pushed
the
servowhitelist
branch
from
October 17, 2018 07:16
a372ff6
to
9cf51b9
Compare
paulrouget
force-pushed
the
servowhitelist
branch
from
October 17, 2018 11:30
9cf51b9
to
c903170
Compare
Merging this in |
paulrouget
added a commit
that referenced
this pull request
Oct 25, 2018
paulrouget
added a commit
to paulrouget/FirefoxReality
that referenced
this pull request
Oct 25, 2018
paulrouget
added a commit
that referenced
this pull request
Oct 26, 2018
paulrouget
added a commit
that referenced
this pull request
Nov 21, 2018
paulrouget
added a commit
that referenced
this pull request
Dec 28, 2018
paulrouget
added a commit
to paulrouget/FirefoxReality
that referenced
this pull request
Jan 10, 2019
paulrouget
added a commit
that referenced
this pull request
Jan 16, 2019
MortimerGoro
pushed a commit
that referenced
this pull request
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for after #498. We only want to show the button for some urls.
I moved the button to the right of the url bar to prevent the UI to "move" too much as the user navigates.
@jdm can you look at the list and tell me if there's anything else you want to add in there?