Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #846 #849 #860 Fixes keyboard focus issues #889

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

keianhzo
Copy link
Contributor

Fixes #846 #849 #860 Avoid URL EditText to gain focus when focus changes

@keianhzo keianhzo requested a review from cvan December 14, 2018 01:34
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #846 #849 #860 Avoid URL EditText to gain focus when focus changes

Tested, and they all work. Fantastic job fixing all three with a small patch! 👍


On a related note, I noticed an issue with <input autofocus> that may be related. But if it's not, I will file a separate issue for this. Let me know.

  1. Load the test case root page: https://webxr.sh/?#autofocus
  2. Click on the link for the test case
  3. Notice the <input autofocus> gets automatically focussed and the keyboard does as well

Compare to this:

  1. Load the test case page directly: https://webxr.sh/autofocus.html (Or go press Back and Forward in history.)
  2. Notice the <input autofocus> gets automatically focussed, but the keyboard does not.

@cvan cvan added this to the v1.2 milestone Dec 14, 2018
@keianhzo
Copy link
Contributor Author

@cvan I've been testing that and it happens but not 100% it seems that under some circumstances GV doesn't call showSoftInput even though the browser view is focused. I don't think is related to this issue and might be GV related so best thing is to open a separate issue.

@cvan
Copy link
Contributor

cvan commented Dec 17, 2018

@cvan I've been testing that and it happens but not 100% it seems that under some circumstances GV doesn't call showSoftInput even though the browser view is focused. I don't think is related to this issue and might be GV related so best thing is to open a separate issue.

filed issue #898 to track this. should I file this on Bugzilla too? and, feel free to add your findings to that issue. thank you.

@cvan cvan merged commit 49ccd1b into master Dec 17, 2018
@cvan cvan deleted the keyboard-focus-fix branch December 17, 2018 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants