Add support for charset and end_of_line
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to just be a dictionary of strings, which meant parsing logic was distributed all over the codebase and applying the settings was kind of a pain. Now we have an object with reasonable types (integers, enums, booleans, etc) that encapsulates all the parsing logic. NOTE: this also makes the binary 64-bit only, but TM2 itself is the same (and I am dropping TM1 support), so this should be fine. (64-bit is required for auto property synthesis/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally: add support for the last missing official EditorConfig features,
end_of_lineandcharset. All the values listed on the EditorConfig documentation: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties.Note the charset
utf-8-bomis not supported—it is listed but discouraged on the EditorConfig homepage, but not listed at all in the actual docs.Fixes #23. Depends on #29.