Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: workflow to autogen a changelog and publish to npm #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iloveitaly
Copy link
Contributor

Copy link
Owner

@Mr0grog Mr0grog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some tooling to publish new versions to NPM is great, but obviously needs to come after #84 or some other similar changes, so this will have to wait a bit. Thank you for working on this, though.

In addition, I’d prefer to have this as a separate workflow that is triggered based on a new tag being added (or manually triggered with the version number to tag with as a workflow-level parameter), and to remove the parts of this workflow that do automatic tagging (the conventional changelog action). I strongly believe that packaged releases should not be automatically published on every change, which this would do, and I also deeply dislike conventional commits-based changelogs (they are better than nothing, but that is about all they are better than — they do a great job of forcing consumers to chase down every PR or commit mentioned, and do a stupendous amount of extra work to understand what’s changed that they need to account for or can make use of; they can make a good starting point to draft release notes from, but that’s not how this workflow works).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants