Change WorkingBlock.examples from ArrayList to HashSet

MrChrisJohnson · Dec 7, 2011 · df7bd47 · df7bd47
1 parent 1f0899b
commit df7bd47
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/main/java/collabstream/streaming/Worker.java b/src/main/java/collabstream/streaming/Worker.java
@@ -144,9 +144,10 @@ private void update(BlockPair bp, WorkingBlock workingBlock) {
 		float[][] userBlock = workingBlock.userBlock;
 		float[][] itemBlock = workingBlock.itemBlock;
 
-		PermutationUtils.permute(workingBlock.examples);
+		TrainingExample[] examples = workingBlock.examples.toArray(new TrainingExample[workingBlock.examples.size()]);
+		PermutationUtils.permute(examples);
 
-		for (TrainingExample ex : workingBlock.examples) {
+		for (TrainingExample ex : examples) {
 			if (ex.numTrainingIters >= config.maxTrainingIters) continue;
 			int i = ex.userId - userBlockStart;
 			int j = ex.itemId - itemBlockStart;

diff --git a/src/main/java/collabstream/streaming/WorkingBlock.java b/src/main/java/collabstream/streaming/WorkingBlock.java
@@ -1,10 +1,11 @@
 package collabstream.streaming;
 
 import java.io.Serializable;
-import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.Set;
 
 public class WorkingBlock implements Serializable {
-	public final ArrayList<TrainingExample> examples = new ArrayList<TrainingExample>();
+	public final Set<TrainingExample> examples = new HashSet<TrainingExample>();
 	public float[][] userBlock = null;
 	public float[][] itemBlock = null;
 	public boolean waitingForBlocks = false;