-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brazilian Portuguese translation #118
Conversation
I can't tell you how I feel right now. I'm so happy. Please give me a little bit time to review. |
I forgot to translate 2 titles in the README, I'm sorry for that. |
Thanks to you, when I was checking the PR, I found a bug, #120 will fix your website month translation. |
I make some changes, Could you please take a look at this commit 44c1a36 ? |
ac551fd
to
7c0e144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked pages are good to go.
7c0e144
to
44c1a36
Compare
I made some small changes to improve the translation. Everything looks really good and I really appreciate the credits. |
Everything is look good. Forgive me for my poor translations. I will update demo page too. I appreciate your time. Thank you. |
28b0437
to
3aa3e3d
Compare
3aa3e3d
to
eacdeeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well all done.
About pull request
What's changed to accomplish [problem / feature] described in issue
This pull request doesn't change any previews code, except adding pt (portuguese) as an option to the main.conf file.
All the translation is nested in pt folder.
I have not translated the William Shakespeare quotes and other examples because those will end up being replaced by other users when using this theme, so I left those in place.
I also translated the README file and named it _README-pt.md (as the same as the Japanese one) and this can be added to the main project page by the main author of the theme. Because this is the author's choice, I have not added a link to the brazilian portuguese README.md file since those are linked directly to the author's of this theme github page.
Please, considere this as a gratitude for your work since I'm using your jekyll theme on my personal blog since yesterday (https://fandangos.github.io) but with only English and Portuguese language options as I don't speak Japanese.