Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brazilian Portuguese translation #118

Merged
merged 5 commits into from
Oct 1, 2022

Conversation

fandangos
Copy link
Contributor

About pull request

  • This pull request adds Brazilian Portuguese translation as an option to the theme.

What's changed to accomplish [problem / feature] described in issue

This pull request doesn't change any previews code, except adding pt (portuguese) as an option to the main.conf file.
All the translation is nested in pt folder.
I have not translated the William Shakespeare quotes and other examples because those will end up being replaced by other users when using this theme, so I left those in place.

I also translated the README file and named it _README-pt.md (as the same as the Japanese one) and this can be added to the main project page by the main author of the theme. Because this is the author's choice, I have not added a link to the brazilian portuguese README.md file since those are linked directly to the author's of this theme github page.

Please, considere this as a gratitude for your work since I'm using your jekyll theme on my personal blog since yesterday (https://fandangos.github.io) but with only English and Portuguese language options as I don't speak Japanese.

@MrGreensWorkshop
Copy link
Owner

I can't tell you how I feel right now. I'm so happy. Please give me a little bit time to review.

@fandangos
Copy link
Contributor Author

I forgot to translate 2 titles in the README, I'm sorry for that.
I've added a new commit and now it should be fully translated.

@MrGreensWorkshop
Copy link
Owner

MrGreensWorkshop commented Sep 30, 2022

Thanks to you, when I was checking the PR, I found a bug, #120 will fix your website month translation.
It is not related to this bug but, there are small things needs to change in this PR. Still checking.

@MrGreensWorkshop
Copy link
Owner

MrGreensWorkshop commented Oct 1, 2022

I make some changes, Could you please take a look at this commit 44c1a36 ?
I also add your name into readme files. Since I used Google translation please check.
I also changed translation for cookies, it's taken from googles page. I think its better to use them for each language. Overall please let me know what you think. Thank you again.

@MrGreensWorkshop MrGreensWorkshop force-pushed the portuguese branch 2 times, most recently from ac551fd to 7c0e144 Compare October 1, 2022 08:10
Copy link
Owner

@MrGreensWorkshop MrGreensWorkshop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked pages are good to go.

@fandangos
Copy link
Contributor Author

I made some small changes to improve the translation.
In portuguese, you can use some words in English and those will be left in the phrase like the original.
If you translate Theme to Tema, it would be spoken before the title of the theme: Tema Mr. Green.
That's why I changed it.

Everything looks really good and I really appreciate the credits.
I'll write about this colaboration on my blog that is powered by Mr Green :))

@MrGreensWorkshop
Copy link
Owner

Everything is look good. Forgive me for my poor translations. I will update demo page too. I appreciate your time. Thank you.

README-pt.md Outdated Show resolved Hide resolved
Copy link
Owner

@MrGreensWorkshop MrGreensWorkshop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well all done.

@MrGreensWorkshop MrGreensWorkshop merged commit 0774474 into MrGreensWorkshop:main Oct 1, 2022
@fandangos fandangos deleted the portuguese branch December 20, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants