Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write and Read nodes reset settings when input in filename field is changed #1492

Closed
rebuilder opened this issue Nov 14, 2016 · 2 comments
Closed

Comments

@rebuilder
Copy link

Natron 2.1.7:
Example:

Create a write node, select Cineon colorspace.

Later on, update the write node's filename to e.g. a new version number.
The colorspace field is reset! Also, if frame range is set to "manual", the input boxes for start and end vanish, although the previously entered numbers are still used for rendering.

Same issue regarding the colorspace exists with read node.

devernay added a commit to MrKepzie/openfx-io that referenced this issue Nov 22, 2016
@devernay devernay added this to the 2.2 milestone Nov 22, 2016
@devernay
Copy link
Collaborator

devernay commented Nov 23, 2016

Expected behaviour

Natron should get the values for all parameters (including hidden parameters such as "ocioInputSpaceSet" for readers and "ocioOutputSpaceSet" for writers) and restore these in the newly-created plugin.

Note that these parameters were just added to fix the colorspace-reset issue on the plugin side, but now work has to be done on Natron itself.

@devernay devernay modified the milestones: 2.1.9, 2.2 Nov 23, 2016
devernay added a commit to MrKepzie/openfx-io that referenced this issue Nov 23, 2016
…orspace if set by user.

- partial fix for MrKepzie/Natron#1492
- Natron has to be fixed too: it recreates the plugin from scratch but
should restore values
@devernay
Copy link
Collaborator

Reader/writer now keep most user-visible parameters. Create a new reader/writer if you want these to be set automatically.

devernay added a commit to MrKepzie/openfx-io that referenced this issue Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants