feat(parser): add optional display-name to layer #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for an optional label property in layers which can match zero or once. In ZMK each layer can be assigned a display-name. One use case for the label is that it can be shown in display widgets. See zmkfirmware/zmk#551
|
It was announced on the ZMK discord that |
huber-th
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My keymap was failing with
sub-expression Layer+ must match at least once. Turns out it was because I have a label assigned to each layer in my keymap which is used in ZMK to show the current layer on displays via widget.My keymap layers start like this
This change adds support for an optional label property in layers which can match zero or once. Potentially the label could be used to print on the images in the top left corner rather than the layer identifier of the keymap.
See zmkfirmware/zmk#551 which is the merged change in ZMK to support using the label to show in display widgets. There is also zmkfirmware/zmk#578 which is to document this optional layer.