Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability use local info.json file #9

Merged
merged 6 commits into from
Jan 15, 2023

Conversation

PikaThonk
Copy link
Contributor

@PikaThonk PikaThonk commented Jan 14, 2023

I have a Kinesis360, which uses zmk. I think that's probably why there's no info.json on the qmk website. However, Kinesis does include an info.json: https://github.com/KinesisCorporation/Adv360-Pro-ZMK/blob/V2.0/config/info.json in their firmware repo.

I added a new parameter -l which lets you specify a local info.json file. Without the parameter, the program functions normally.

It seems to work properly. Although you do need to edit the adv360.keymap file by deleting this part near the top:

behaviors {
      #include "macros.dtsi"

      hm: homerow_mods {
          compatible = "zmk,behavior-hold-tap";
          label = "HOMEROW_MODS";
          #binding-cells = <2>;
          tapping-term-ms = <200>;
          quick_tap_ms = <175>;
          flavor = "tap-preferred";
          bindings = <&kp>, <&kp>;
      };
    };

Anyway, not sure this is useful at all to anyone else or not. And also, I don't really kno how to write anything in Go and I'm not at all tuned into the zmk/qmk/custom keyboard community so this is probably very far from perfect. But I figured I'd open up a PR just in case anyone else finds this useful!

adv360_default_layer
adv360_keypad
adv360_mod

@MrMarble
Copy link
Owner

Thanks for your contribution! Great Idea!

Reading through that Kinesis360 info file I see only some keys have the w property, I assume every other has a width of 1.

Could you try and edit this conditional where the image is generated to add a default width (like is done with the H property) and see if the image is fixed?
https://github.com/MrMarble/zmk-viewer/blob/master/internal/lib/generate.go#L68-L72

@MrMarble MrMarble self-assigned this Jan 14, 2023
@MrMarble MrMarble added the enhancement New feature or request label Jan 14, 2023
@PikaThonk
Copy link
Contributor Author

ooo good call—looks like that fixes it
adv360_default_layer

@MrMarble MrMarble merged commit 640fa66 into MrMarble:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants