Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README update about yarn environment #29

Closed
MrOrz opened this issue Feb 9, 2017 · 1 comment
Closed

README update about yarn environment #29

MrOrz opened this issue Feb 9, 2017 · 1 comment

Comments

@MrOrz
Copy link
Member

MrOrz commented Feb 9, 2017

As the meeting note find out, it is not necessary to assume developers don't have node environment installed.

If the developer has their node environment installed, current install script can be more straight-forward. At least, yarn install can be carried out before docker-compose up, providing a smoother first-time developing experience.
@MrOrz
Copy link
Member Author

MrOrz commented Feb 27, 2017

Already done.

@MrOrz MrOrz closed this as completed Feb 27, 2017
godgunman pushed a commit that referenced this issue Feb 29, 2020
@MrOrz
Merge pull request #29 from cofacts/article-reply-feedback-comment
fa28c4f 
Add comment field to articlereplyfeedbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrOrz