Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAvatarImageByID contentType unavailable #271

Closed
dreamboyx1 opened this issue Aug 3, 2023 · 1 comment · Fixed by #281
Closed

getAvatarImageByID contentType unavailable #271

dreamboyx1 opened this issue Aug 3, 2023 · 1 comment · Fixed by #281
Assignees
@MrRefactoring
Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project.
Milestone
v3.0.0

Comments

@dreamboyx1
Copy link

A call to the version3Client.avatars.getAvatarImageByID can return binary data that represents a number of different image formats that do not necessarily represent the desire format specified in the call params. It would be super helpful if the client were able to return the content-type header mime type. Or, perhaps there is a way to access the headers?

Otherwise, I'm stuck trying to figure out the image type based on the binary data.
@MrRefactoring MrRefactoring added the enhancement Denotes a suggestion or request aimed at improving or adding new features to the project. label Aug 11, 2023
@MrRefactoring MrRefactoring self-assigned this Oct 7, 2023
MrRefactoring added a commit that referenced this issue Oct 8, 2023
@MrRefactoring
[#271]: initial template added
92c305e
@MrRefactoring MrRefactoring linked a pull request Oct 8, 2023 that will close this issue
[#271]: Update getAvatarImageByID to include contentType in return type #281
Merged
MrRefactoring added a commit that referenced this issue Oct 9, 2023
@MrRefactoring
[#271]: lint fix
c29544a
@MrRefactoring MrRefactoring added this to the v3.0.0 milestone Oct 9, 2023
MrRefactoring added a commit that referenced this issue Oct 9, 2023
@MrRefactoring
[#271]: fixes added
09b5a97
MrRefactoring added a commit that referenced this issue Oct 9, 2023
@MrRefactoring
[#271]: getAvatarImageByID updated for version2
19d8e45
MrRefactoring added a commit that referenced this issue Oct 9, 2023
@MrRefactoring
[#271]: test project name updated
88b1c90
MrRefactoring added a commit that referenced this issue Oct 9, 2023
@MrRefactoring
[#271]: Update getAvatarImageByID to include contentType in retur…
827a676 
…n type (#281)

* [#271]: initial template added

* [#271]: lint fix

* [#271]: fixes added

* [#271]: getAvatarImageByID updated for version2

* [#271]: test project name updated
@MrRefactoring
Copy link
Owner

Will be released in v3.0.0

MrRefactoring added a commit that referenced this issue Oct 15, 2023
@MrRefactoring
V3.0.0 (#285)
7d8bffb 
* [#271]: Update `getAvatarImageByID` to include `contentType` in return type (#281)

* [#271]: initial template added

* [#271]: lint fix

* [#271]: fixes added

* [#271]: getAvatarImageByID updated for version2

* [#271]: test project name updated

* NodeJS 10 version life was ended

* JWT and OAuth auths removed (#284)

* JWT and OAuth auths removed

* XOR3 added

* unit tests fixed

* build fixed

* Deprecation stuff removed (#283)

* agile deprecation stuff removed

* version2 deprecation stuff removed

* test fixes

* version3 deprecated properties removed

* no-namespaces rule applied

* integration tests fixes

* old stuff removed

* newErrorHandling removed

* avatar api updates (#286)

* parameters types improvements

* parameters types improvements

* build fix

* parameters types improvements

* CHANGELOG.md updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrRefactoring MrRefactoring

Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

[#271]: Update getAvatarImageByID to include contentType in return type MrRefactoring/jira.js
2 participants
@MrRefactoring @dreamboyx1