Allow initiating client without authentication

[violine1101]

While switching over from jira-connector to jira.js, I ran into an issue with setting up the client; in particular, it would crash every time I tried to initiate a client without any authentication.

Exception has occurred: TypeError [ERR_HTTP_INVALID_HEADER_VALUE]: Invalid value "undefined" for header "Authorization"
  at ClientRequest.setHeader (_http_outgoing.js:529:3)
    at new ClientRequest (_http_client.js:241:14)
    at Object.request (https.js:314:10)
    at RedirectableRequest._performRequest (.../node_modules/follow-redirects/index.js:169:24)
    at new RedirectableRequest (.../node_modules/follow-redirects/index.js:66:8)
    at Object.wrappedProtocol.request (.../node_modules/follow-redirects/index.js:307:14)
    at dispatchHttpRequest (.../node_modules/axios/lib/adapters/http.js:179:25)
    at new Promise (<anonymous>)
    at httpAdapter (.../node_modules/axios/lib/adapters/http.js:21:10)
    at dispatchRequest (.../node_modules/axios/lib/core/dispatchRequest.js:52:10)

Since I'm working on a public JIRA instance and my use case does only require read but not write access, I'd expect this module to allow me to use the APIs that are also publicly available.

This used to work without issues in jira-connector.

I found that the issue simply was that the getAuthentication helper function returned undefined if no authentication was specified. Replacing this undefined with an empty string solved the issue.

There was a test that explicitly checked for this undefined (which I changed in this PR), so I'm not sure if this was intentional and this issue is deeper in the core of axios?

[MrRefactoring]

Do I understand correctly that initialization looks like this:

const client = new Client({ host: '...' })

[MrRefactoring]

I got repro

[MrRefactoring]

I think we need to change the logic in the sendRequest method:

public async sendRequest(request: AxiosRequestConfig, callback?: Callback): Promise<any> {
    try {
      request.headers = request.headers || {};

      const authorization = request.headers.Authorization || getAuthentication(this.config, request);

      if (!!authorization) {
        request.headers.Authorization = authorization;
      }

      const response = await this.requestInstance.request(request);
...

[violine1101]

Do I understand correctly that initialization looks like this:

const client = new Client({ host: '...' })

Yes, that's what's what causes the crash.

I think we need to change the logic in the sendRequest method:

From what I can tell, that should work too, yeah.

[MrRefactoring]

Do I understand correctly that initialization looks like this:

const client = new Client({ host: '...' })

Yes, that's what's what causes the crash.

I think we need to change the logic in the sendRequest method:

From what I can tell, that should work too, yeah.

Will you make changes or should I do it?

[violine1101]

I've committed your suggestion to my branch 👍

[MrRefactoring]

Thank you for your contribution!

[MrRefactoring]

Fixed in version 1.6.1