fix: halo renderer bug messing up rendering of various mods

MrTJP · Nov 30, 2023 · 43b5a8a · 43b5a8a
1 parent 196fa19
commit 43b5a8a
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/core/src/main/java/mrtjp/projectred/core/client/HaloRenderer.java b/core/src/main/java/mrtjp/projectred/core/client/HaloRenderer.java
@@ -176,6 +176,16 @@ public static void onRenderWorldLastEvent(final RenderLevelLastEvent event) {
         // Unfabulous rendering. Batched rendering doesn't seem to work from stage events when not
         // on fabulous for some reason, so we have to do it here instead.
         if (!isFabulous()) {
+            if (levelLights.isEmpty()) return;
+
+            // Poll all pending lights from queue
+            List<LevelLight> lightList = new LinkedList<>();
+            LevelLight l;
+            while ((l = levelLights.poll()) != null) {
+                lightList.add(l);
+            }
+
+            // Prepare render
             Vec3 cam = Minecraft.getInstance().getEntityRenderDispatcher().camera.getPosition();
             PoseStack stack = event.getPoseStack();
             stack.pushPose();
@@ -185,22 +195,17 @@ public static void onRenderWorldLastEvent(final RenderLevelLastEvent event) {
             ccrs.reset();
             MultiBufferSource.BufferSource buffers = Minecraft.getInstance().renderBuffers().bufferSource();
 
-            // Build light list
-            List<LevelLight> lightList = new LinkedList<>();
-            LevelLight l;
-            while ((l = levelLights.poll()) != null) {
-                lightList.add(l);
-            }
-
             // Render to normal render target for primary visuals
             ccrs.bind(HALO_GLOW_RENDER_TYPE, buffers, stack);
             for (LevelLight light : lightList) {
                 renderToCCRS(ccrs, light.box, light.colour, light.t, HaloContext.LEVEL_RENDERER);
             }
+
+            // Finish render
             buffers.endBatch();
+            stack.popPose();
         }
 
-
         // Fabulous bloom post-processing effects rendered here instead of during stage
         if (isFabulous() && postChainFlushPending) {
             postChainFlushPending = false;