Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed NEI has build errors #7

Closed
tetious opened this issue Jul 11, 2013 · 3 comments
Closed

Distributed NEI has build errors #7

tetious opened this issue Jul 11, 2013 · 3 comments

Comments

@tetious
Copy link
Contributor

tetious commented Jul 11, 2013

It seems that the version of NEI that the build script downloads has several minor build errors that must be manually corrected before the setup can commence. I'm thinking you fixed these in your local copy but forgot to include them in the NEI source distro on dropbox.

All are in src/minecraft/codechicken/nei/GuiPotionCreator.java:

Line 45 should read:
public void drawSlotBox(float frame)

Line 51 should read:
public void drawOverlay(float frame)

Line 68 should read:
protected void drawSlot(int slot, int x, int y, int mx, int my, boolean selected, float frame)

@MrTJP
Copy link
Owner

MrTJP commented Jul 11, 2013

I was trying to resolve this but I'm afraid you have to do it manually. I'm pretty sure it's on CB's side.

On Jul 10, 2013, at 9:51 PM, Greg Lincoln notifications@github.com wrote:

It seems that the version of NEI that the build script downloads has several minor build errors that must be manually corrected before the setup can commence. I'm thinking you fixed these in your local copy but forgot to include them in the NEI source distro on dropbox.

All are in GuiPotionCreator.java:

Line 45 should read:
public void drawSlotBox(float frame)

Line 51 should read:
public void drawOverlay(float frame)

Line 68 should read:
protected void drawSlot(int slot, int x, int y, int mx, int my, boolean selected, float frame)


Reply to this email directly or view it on GitHub.

@tetious
Copy link
Contributor Author

tetious commented Jul 11, 2013

Yep, I agree. He fixed it in a changeset that is up on bitbucket. I was thinking of trying to rework the build script to use a specific changeset there instead, assuming that approach makes sense to you.

@tetious
Copy link
Contributor Author

tetious commented Jul 11, 2013

This was probably all obvious to most folks, but this was my first time fiddling with all this, so it took a lot of messing about to figure out where it was going wrong. :)

MrTJP pushed a commit that referenced this issue Jul 11, 2013
Possible fix for issue #7
@MrTJP MrTJP closed this as completed Jul 15, 2013
MrTJP added a commit that referenced this issue Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants