Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend keeps downloading despite server being up-to-date #11

Closed
x1p opened this issue May 29, 2024 · 4 comments
Closed

Amend keeps downloading despite server being up-to-date #11

x1p opened this issue May 29, 2024 · 4 comments
Assignees
Labels
bug Something isn't working paper Paper issues purpur Purpur issues

Comments

@x1p
Copy link

x1p commented May 29, 2024

Describe the problem
Amend downloads "newer" version despite running the latest server version
Similar to issue: #6

To Reproduce
Steps to reproduce the behavior:

  1. Download latest Purpur 1.20.6
  2. Run server with that
  3. Stop server
  4. Check log to see that Amend downloads "latest" version

Info:
Please add the following info below so I can have an understanding.

Version of MC: 1.20.6
Version of Amend: 1.7.4--V1.20.6
Server-Type: PURPUR
Host (if there is any): {HOST OR N/A}

Additional content
Log:

Log file, click to open

</details>
[22:15:07 INFO]: [Amend] Loading server plugin Amend v1.7.4--V.1.20.6
[22:15:07 INFO]: [Amend] Enabling Amend v1.7.4--V.1.20.6
[22:15:07 INFO]: [Amend] Amend is on standby, ready for updates on shutdown.
[22:15:07 INFO]: [PlugMan] Amend has been loaded and enabled.
[22:15:07 INFO]: [Amend] You are using the latest version of Amend.
ver
[22:15:12 INFO]: Checking version, please wait...
[22:15:12 INFO]: Current Purpur Version: 1.20.6-2218-ec1b4fa (MC: 1.20.6)*
* You are running the latest version
Previous: 1.20.6-2217-2842b97 (MC: 1.20.6)
(Daemon) Server marked as STOPPING
stop
[22:15:26 INFO]: Stopping the server
[22:15:26 INFO]: Stopping server
[22:15:26 INFO]: [Amend] Disabling Amend v1.7.4--V.1.20.6
[22:15:26 INFO]: [Amend] Started Update Check...
[22:15:26 WARN]: [Amend] -------------------------------
[22:15:26 INFO]: [Amend] Amend
[22:15:26 INFO]: [Amend] Server-Type Selected: PURPUR
[22:15:26 INFO]: [Amend] Current Version: -ec1b4fa (MC: 1.20.6)
[22:15:26 WARN]: [Amend] Version is NOT up to date! Newest PURPUR version is 2218
[22:15:26 INFO]: [Amend] Downloading update and applying to purpurclip.jar...
[22:15:28 INFO]: [Amend] Update Completed!
[22:15:28 WARN]: [Amend] -------------------------------
[22:15:31 INFO]: [Amend] Successfully updated and disabled Amend!

@x1p x1p added the bug Something isn't working label May 29, 2024
@MrTronMan
Copy link
Owner

MrTronMan commented Jun 2, 2024

Hi! First off thank you, for using Amend. I think I know the issue. It checks by API and comparing the version as a string...Purpur decided to change this, I will look into this now thank you!

@MrTronMan MrTronMan self-assigned this Jun 2, 2024
@MrTronMan
Copy link
Owner

You helped me find errors that show up for how Amend recognizes newer versions of Paper and Purpur, it was too much so I rewrote the entire way I get versions haha, thank you!

MrTronMan added a commit that referenced this issue Jun 2, 2024
- rewrote the way Amend gets server version since paper changed (#11)
- cleaned code up
@MrTronMan MrTronMan added purpur Purpur issues paper Paper issues labels Jun 2, 2024
@x1p
Copy link
Author

x1p commented Jun 2, 2024

:)
Works like a charm again.
Thank you

@x1p x1p closed this as completed Jun 2, 2024
@MrTronMan
Copy link
Owner

My pleasure, thank you for using Amend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working paper Paper issues purpur Purpur issues
Projects
None yet
Development

No branches or pull requests

2 participants