Revert PR servo#1554 because it's wrong.

Ms2ger · Jan 25, 2014 · d6b5015 · d6b5015 · SimonSapin · Jan 25, 2014
1 parent 5ca55bb
commit d6b5015
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 4 deletions.
diff --git a/src/components/script/dom/element.rs b/src/components/script/dom/element.rs
@@ -157,16 +157,15 @@ impl Element {
         }).map(|&x| x)
     }
 
-    #[inline]
     pub unsafe fn get_attr_val_for_layout(&self, namespace: Namespace, name: &str) 
                                           -> Option<&'static str> {
+        // FIXME: only case-insensitive in the HTML namespace (as opposed to SVG, etc.)
+        let name = name.to_ascii_lower();
         self.attrs.iter().find(|attr: & &@mut Attr| {
             // unsafely avoid a borrow because this is accessed by many tasks
             // during parallel layout
-            // FIXME: only case-insensitive in the HTML namespace (as opposed to SVG, etc.)
             let attr: ***Box<Attr> = cast::transmute(attr);
-            name.eq_ignore_ascii_case((***attr).data.local_name) &&
-                (***attr).data.namespace == namespace
+            name == (***attr).data.local_name && (***attr).data.namespace == namespace
        }).map(|attr| {
             let attr: **Box<Attr> = cast::transmute(attr);
             cast::transmute((**attr).data.value.as_slice())

diff --git a/src/test/ref/basic.list b/src/test/ref/basic.list
@@ -23,3 +23,4 @@
 == font_size_percentage.html font_size_em_ref.html
 == position_fixed_a.html position_fixed_b.html
 == img_size_a.html img_size_b.html
+== upper_id_attr.html upper_id_attr_ref.html
diff --git a/src/test/ref/upper_id_attr.html b/src/test/ref/upper_id_attr.html
@@ -0,0 +1,9 @@
+<!doctype html>
+<style>
+div { height: 2em; background: green; }
+#id { background: red; }
+</style>
+<div></div>
+<script>
+document.body.firstChild.setAttributeNS("", "ID", "id");
+</script>
diff --git a/src/test/ref/upper_id_attr_ref.html b/src/test/ref/upper_id_attr_ref.html
@@ -0,0 +1,5 @@
+<!doctype html>
+<style>
+div { height: 2em; background: green; }
+</style>
+<div></div>