Highlight curly apostrophe

[sebastienserre]

Highlight when a curly apostophe is used

[audrasjb]

Hey, thanks for the enhancement.
Looks good to me, I only wonder if we want to check !gd_get_setting('curly_apostrophe_warning') or gd_get_setting('curly_apostrophe_warning') 🤔

[audrasjb]

Approved.

[Mte90]

Can I have a translation string/page where I can test it before merge and do a new release?

[sebastienserre]

Hello @Mte90 this string https://translate.wordpress.org/projects/wp/dev/fr/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=9145706&filters%5Btranslation_id%5D=70602786 contains a curly apostrophe and should be higlithed in yellow

[Mte90]

Tested and works!
Just for the future if you can update also the changelog, I will do it for this case :-D

[garretthyder]

Nice, taking a glance I wonder if we highlight all 'curly' quotes (single/double right/left)? This PR currently only does the apostrophe (single right quote). Just a thought while the topic is active.

[Mte90]

Just because we are talking about highlighting symbols, if we do a text field in the settings where the user inserts the symbols that want highlighted?
In this way we can support more symbols and the users can insert the ones prefer.

[garretthyder]

I like that, we can default to pre-generated characters and allow users to disable or customize the highlighted characters.

[Mte90]

Created an issue for that :-D