Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make stable ullage stable #891

Merged
merged 1 commit into from Jun 1, 2017
Merged

make stable ullage stable #891

merged 1 commit into from Jun 1, 2017

Commits on Jun 1, 2017

  1. make stable ullage stable

    its probably obvious that this should have been fixed this way.
    
    however, i was considering vessels which had means of ullage and when i
    was considering how far MJ should ullage until it tried to light the
    engine i was like "why not _very_ stable, that's better right?"
    
    but for something like a sounding rocket where it is as ullaged as its
    ever going to get, you want to allow users to throttle with 'stable' as
    well.  right now if the prop status falls from 'very stable' to 'stable'
    before you hit the throttle it breaks your launch.
    
    really for sounding rockets users should turn this feature off.
    
    should also consider autodetecting sounding rockets (if there's no
    other engines or RCS on the craft, it'll never ullage, so this whole
    feature is a bit breaking if its checked).
    
    Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
    lamont-granquist committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    8ae218a View commit details
    Browse the repository at this point in the history