one more ullage refactoring #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- VesselState now exposes the lowestUllage condition rather than stableUllage - The "prevent unstable ignitions" box now only does what it says it does. If its checked, ullage must be stable. - Introduced a new "Use RCS to ullage" checkbox, and moved the auto-RCS ullaging to this function. It is a bit smarter and does nothing if there's no ModuleRCS active. It will also enable the RCS action group automatically (if there is ModuleRCS to activate) The latter function should pretty much be safe to run with all the time, since stuff like sounding rockets don't have any RCS. Auto-RCS should also not get confused by RCS in probe modules since the RCS module needs to be enabled, and with KSP >= 1.2.x we all should be staging our RCS properly. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VesselState now exposes the lowestUllage condition rather than
stableUllage
The "prevent unstable ignitions" box now only does what it says
it does. If its checked, ullage must be stable.
Introduced a new "Use RCS to ullage" checkbox, and moved the
auto-RCS ullaging to this function. It is a bit smarter and does
nothing if there's no ModuleRCS active. It will also enable the
RCS action group automatically (if there is ModuleRCS to activate)
The latter function should pretty much be safe to run with all the
time, since stuff like sounding rockets don't have any RCS.
Auto-RCS should also not get confused by RCS in probe modules since
the RCS module needs to be enabled, and with KSP >= 1.2.x we all
should be staging our RCS properly.
Signed-off-by: Lamont Granquist lamont@scriptkiddie.org