Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sveltekit route refactor + initial load #599

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Conversation

eyeseast
Copy link
Contributor

@eyeseast eyeseast commented Jul 15, 2024

#522

  • move /app/ to /documents/ so we don't have that missing route
  • move /app/upload/ to /upload/
  • move /app/add-ons/ to /add-ons/
  • move /app/projects/ to either /projects/ or /documents/projects/ (there may be a conflict with embeds)

This doesn't do any redirects, just moves routes.

#485 is also done here.

Copy link

github-actions bot commented Jul 15, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 28.1% 3639 / 12947
🔵 Statements 28.1% 3639 / 12947
🔵 Functions 32.72% 72 / 220
🔵 Branches 53.02% 193 / 364
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/components/addons/AddOnListItem.svelte 100% 100% 100% 100%
src/lib/components/addons/AddOnsNavigation.svelte 100% 100% 100% 100%
src/lib/components/forms/ConfirmDelete.svelte 0% 0% 0% 0% 1-65
src/lib/components/forms/DocumentUpload.svelte 100% 25% 0% 100%
src/lib/components/navigation/Breadcrumbs.svelte 100% 100% 100% 100%
src/lib/components/projects/ProjectListItem.svelte 0% 0% 0% 0% 1-104
src/lib/utils/search.ts 96.61% 88.88% 83.33% 96.61% 13-14
src/routes/+layout.svelte 0% 0% 0% 0% 1-25
src/routes/+page.ts 0% 0% 0% 0% 1-12
src/routes/(pages)/home/+page.svelte 0% 0% 0% 0% 1-250
src/routes/documents/[id]-[slug]/+layout.svelte 0% 0% 0% 0% 1-88
src/routes/documents/[id]-[slug]/+layout.ts 0% 0% 0% 0% 1-46
src/routes/documents/[id]-[slug]/+page.server.ts 0% 0% 0% 0% 1-129
Generated in workflow #215

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 691bac6
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6696a673d5bfba0008032a34
😎 Deploy Preview https://deploy-preview-599.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eyeseast eyeseast changed the title Sveltekit route refactor Sveltekit route refactor + initial load Jul 16, 2024
This was linked to issues Jul 16, 2024
Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change, otherwise excellent! Let's merge 👍

Co-authored-by: Allan Lasser <lasser.allan@gmail.com>
@eyeseast eyeseast merged commit 796fbe4 into sveltekit Jul 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize URL structure Decide initial loading flow
2 participants