Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDrawer - Text not displayed correctly #2888

Open
1 of 2 tasks
wall-code-solutions opened this issue Sep 29, 2021 · 10 comments · May be fixed by #7823
Open
1 of 2 tasks

MudDrawer - Text not displayed correctly #2888

wall-code-solutions opened this issue Sep 29, 2021 · 10 comments · May be fixed by #7823
Labels
bug Something does not work as intended/expected good first issue Good for newcomers

Comments

@wall-code-solutions
Copy link

Bug type

Component

Component name

MudDrawer

What happened?

Screenshot

image

Expected behavior

Maybe hide the text?

Reproduction link

https://try.mudblazor.com/snippet/GuwPYtcDoUAnzKCQ

Reproduction steps

...

Relevant log output

No response

Version (bug)

5.1.5

Version (working)

No response

What browsers are you seeing the problem on?

Chrome

On what operating system are you experiencing the issue?

Windows

Pull Request

  • I would like to do a Pull Request

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Garderoben Garderoben added bug Something does not work as intended/expected hacktoberfest Hacktoberfest 2021 and removed triage labels Sep 30, 2021
@Nickztar
Copy link
Contributor

Nickztar commented Oct 1, 2021

I could fix this. Does kind of seem like a intentional part in the css (see link). It checks so there is a icon but hiding it seems like a more robust solution. Could possibly be useful to not hide if anyone uses it with like one letter intead of a icon, can do a PR for it.
_navmenu.scss

@wall-code-solutions
Copy link
Author

DevExpress has a nice solution: https://devexpress.github.io/devextreme-vue-template/#/tasks

@Nickztar
Copy link
Contributor

Nickztar commented Oct 1, 2021

Do you mean the hiding of the items in the group? In that case that should already be the case for the drawer. This is for items not in group and also missing icon.

@wall-code-solutions
Copy link
Author

Look here https://try.mudblazor.com/snippet/mEwlFEOlhkYSUKoP
Items without icons in the group has same behavior.

I think they should all be hidden / expand automatically, like DevExpress it does.

@Garderoben
Copy link
Member

Do you mean the hiding of the items in the group? In that case that should already be the case for the drawer. This is for items not in group and also missing icon.

I would go with hide them for now should be simple enough. Please update the Docs and state that no icons then it will not show. in minimode and closed.

@cptcrunchy
Copy link
Contributor

What about a "default" icon?

@JonBunator JonBunator added the good first issue Good for newcomers label Oct 7, 2021
@cptcrunchy
Copy link
Contributor

Any traction on this issue? I was looking to work on this if no one else is assigned to it.

@JonBunator JonBunator removed the hacktoberfest Hacktoberfest 2021 label Nov 1, 2021
@JonBunator JonBunator linked a pull request Nov 3, 2021 that will close this issue
1 task
@WhiteOlivierus
Copy link
Contributor

WhiteOlivierus commented Dec 24, 2021

I'm looking at picking up this one, what if we do it like with profile pictures where they take the first letter of your name and last name and display that. Then it wouldn't be hidden and still be clearer to the end-user.

like this
https://mudblazor.com/components/avatar#usage

@Christiancvdh
Copy link

I am unable to tick the "I would like to do a Pull Request" on this problem and other do I need to enable anything?

@ScarletKuro
Copy link
Member

ScarletKuro commented Nov 11, 2023

I am unable to tick the "I would like to do a Pull Request" on this problem and other do I need to enable anything?

You can only tick it on the issues that you have created, not other person's issues. You can just create a PR and reference this issue, and it will be closed automatically once your PR is approved and merged.

@WhiteOlivierus WhiteOlivierus linked a pull request Nov 28, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants