Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add tooltips for enum types showing enum constants #3172

Merged
merged 8 commits into from
Nov 3, 2021
Merged

Docs: Add tooltips for enum types showing enum constants #3172

merged 8 commits into from
Nov 3, 2021

Conversation

iwis
Copy link
Contributor

@iwis iwis commented Oct 27, 2021

Description

This commit adds a tooltip with the possible enum constants for enum type properties. It implements, at least in large part, point no. 3 of the #1020 issue.

How Has This Been Tested?

I checked visually several properties. I checked it on: Blazor Server and WebAssembly, desktop and mobile.

The tooltip looks like this:

Enum type tooltip

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

✔️ The PR is submitted to the correct branch (dev).
✔️ My code follows the code style of this project.

@mudbot mudbot bot added enhancement New feature or request needs review labels Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #3172 (0b3f40c) into dev (659b0c6) will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3172      +/-   ##
==========================================
+ Coverage   88.24%   88.51%   +0.27%     
==========================================
  Files         289      289              
  Lines       12875    12859      -16     
==========================================
+ Hits        11361    11382      +21     
+ Misses       1514     1477      -37     
Impacted Files Coverage Δ
src/MudBlazor/Themes/Models/Typography.cs 100.00% <0.00%> (ø)
...r/Components/Autocomplete/MudAutocomplete.razor.cs 91.11% <0.00%> (+13.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659b0c6...0b3f40c. Read the comment docs.

@JonBunator JonBunator added docs Related to docs needs changes and removed needs review labels Nov 2, 2021
@iwis iwis requested a review from JonBunator November 2, 2021 21:09
Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :)

@JonBunator JonBunator linked an issue Nov 3, 2021 that may be closed by this pull request
2 tasks
@JonBunator JonBunator merged commit 33db3d5 into MudBlazor:dev Nov 3, 2021
@iwis iwis deleted the feature/docs-enum-info branch November 3, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants