Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete, Select and Textfield: Fixes for RTL #1789

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

JonBunator
Copy link
Member

Fixes in https://github.com/Garderoben/MudBlazor/issues/92#issuecomment-724748845:
Autocomplete text and position of arrow
Select text and arrow position + Select items in dropdown
Textfield helper text and label text

textfield

When the InputTpye of MudTextFields is set to InputType.Email or InputType.Telephone the orientation of the textfield automatically changes to ltr. As described here: https://rtlstyling.com/posts/rtl-styling/#form-inputs
grafik
grafik

@JonBunator JonBunator changed the title Fix/inputs rtl Fixes inputs in RTL Jun 5, 2021
@T-Alkathiri
Copy link

Thank you very much for your efforts.

@JonBunator
Copy link
Member Author

Thank you very much for your efforts.

No worries :) There are still a few things that need to be fixed. But I think we can fully support RTL in the next weeks. May I ask you two short questions regarding RTL?

  1. In RTL would these progress circles spin the other way around?
    spin

  2. Should switches get flipped in RTL? Like this:
    grafik
    Or do they stay like this:
    grafik

Thank you :)

@henon
Copy link
Collaborator

henon commented Jun 8, 2021

Wow, this looks so awesome. Would you add that to the RTL docs page too?

@henon henon changed the title Fixes inputs in RTL Autocomplete, Select and Textfield: Fixes for RTL Jun 8, 2021
@henon henon merged commit 0ed5c7e into MudBlazor:dev Jun 8, 2021
@JonBunator JonBunator deleted the fix/inputs-rtl branch June 8, 2021 21:47
@JonBunator
Copy link
Member Author

Wow, this looks so awesome. Would you add that to the RTL docs page too?

What exactly do you mean? Should I include something like the image I posted? Something like this:
grafik

@henon
Copy link
Collaborator

henon commented Jun 9, 2021

yeah, wouldn't that be great on the RTL page?

@henon henon mentioned this pull request Jun 9, 2021
@JonBunator
Copy link
Member Author

yeah, wouldn't that be great on the RTL page?

Sure, great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants