Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThemeProvider: Add TextTransform parameter to typography #3273

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

JonBunator
Copy link
Member

@JonBunator JonBunator commented Nov 5, 2021

Description

Adds TextTransform parameter to typography

How Has This Been Tested?

I set all typographies to text-transform: uppercase and checked that all texts in the docs are uppercase.
I set text-transform of buttons to lowercase and checked that the text is lowercase

Checklist:

✔️ The PR is submitted to the correct branch (dev).
✔️ My code follows the code style of this project.
❌ I've added relevant tests.

@mudbot mudbot bot added enhancement New feature or request needs review labels Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #3273 (aaaa4e9) into dev (b51f45a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3273      +/-   ##
==========================================
+ Coverage   89.66%   89.67%   +0.01%     
==========================================
  Files         312      312              
  Lines        9547     9562      +15     
==========================================
+ Hits         8560     8575      +15     
  Misses        987      987              
Impacted Files Coverage Δ
...Components/ThemeProvider/MudThemeProvider.razor.cs 98.68% <100.00%> (+0.08%) ⬆️
src/MudBlazor/Themes/Models/Typography.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51f45a...aaaa4e9. Read the comment docs.

Copy link
Member

@Garderoben Garderoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for doing this, and love that you made with the scss file, prob allot of stuff we could make cleaner if i did that from the beginning :D

@Garderoben Garderoben modified the milestones: 5.2.1, 6.0.0 Nov 5, 2021
@Garderoben Garderoben merged commit f6667e0 into MudBlazor:dev Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants