Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormComponent: Support validation with DataAnnotation attributes without EditContext #3442

Merged

Conversation

A6blpka
Copy link
Contributor

@A6blpka A6blpka commented Nov 28, 2021

This also fixes the resolution of field names when using the For method without EditForm (EditContext)

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@JonBunator JonBunator added needs review bug Something does not work as intended/expected labels Nov 29, 2021
@mikes-gh mikes-gh changed the title MudFormComponent: Added validation with DataAnnotation attributes without EditContext FormComponent: Added validation with DataAnnotation attributes without EditContext Dec 2, 2021
@henon
Copy link
Collaborator

henon commented Feb 5, 2022

I will review this shortly. Can you merge dev and push please?

@henon
Copy link
Collaborator

henon commented Feb 24, 2022

If you can please resolve the conflicts. I'll review then.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #3442 (99560dd) into dev (52d811f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3442      +/-   ##
==========================================
+ Coverage   91.12%   91.13%   +0.01%     
==========================================
  Files         351      351              
  Lines       11623    11625       +2     
==========================================
+ Hits        10591    10594       +3     
+ Misses       1032     1031       -1     
Impacted Files Coverage Δ
src/MudBlazor/Base/MudFormComponent.cs 87.93% <100.00%> (+0.10%) ⬆️
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 91.98% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d811f...99560dd. Read the comment docs.

@henon henon changed the title FormComponent: Added validation with DataAnnotation attributes without EditContext FormComponent: Add validation with DataAnnotation attributes without EditContext Feb 25, 2022
Copy link
Collaborator

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@henon henon changed the title FormComponent: Add validation with DataAnnotation attributes without EditContext FormComponent: Support validation with DataAnnotation attributes without EditContext Feb 25, 2022
@henon henon merged commit be9c868 into MudBlazor:dev Feb 25, 2022
@henon henon modified the milestones: 6.0.7, 6.0.8 Feb 25, 2022
@henon
Copy link
Collaborator

henon commented Feb 25, 2022

Thanks!

jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…ithout EditContext (MudBlazor#3442)

Co-authored-by: Meinrad Recheis <meinrad.recheis@gmail.com>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…ithout EditContext (MudBlazor#3442)

Co-authored-by: Meinrad Recheis <meinrad.recheis@gmail.com>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…ithout EditContext (MudBlazor#3442)

Co-authored-by: Meinrad Recheis <meinrad.recheis@gmail.com>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…ithout EditContext (MudBlazor#3442)

Co-authored-by: Meinrad Recheis <meinrad.recheis@gmail.com>
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
…ithout EditContext (MudBlazor#3442)

Co-authored-by: Meinrad Recheis <meinrad.recheis@gmail.com>
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
…ithout EditContext (MudBlazor#3442)

Co-authored-by: Meinrad Recheis <meinrad.recheis@gmail.com>
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
…ithout EditContext (MudBlazor#3442)

Co-authored-by: Meinrad Recheis <meinrad.recheis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants