Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudSimpleTable, MudTable, MudDataGrid: Fix missing border radius when using FixedHeader #4212

Merged
merged 1 commit into from Mar 27, 2022

Conversation

BenWhite27
Copy link
Contributor

@BenWhite27 BenWhite27 commented Mar 19, 2022

This PR fixes a missing top right border radius for MudTable, MudSimpleTable, and presumably MudDataGrid when using the FixedHeader feature. The issue is initially only present when the scrollbar is not visible however on more extreme border radius settings the table header cell background can be seen with or without the scroll bar.

Demonstrated here.
https://try.mudblazor.com/snippet/QaQmkdFDygPwuJVy

Description

I've applied the equivalent style on :first-child to :last-child for these components.

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Before:
image

After:
image

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@JonBunator JonBunator added the bug Something does not work as intended/expected label Mar 27, 2022
Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you :)

@JonBunator JonBunator added this to the 6.0.9 milestone Mar 27, 2022
@JonBunator JonBunator merged commit ade69e0 into MudBlazor:dev Mar 27, 2022
@JonBunator JonBunator changed the title CSS Fix: MudTable and MudSimpleTable missing border radius MudSimpleTable, MudTable, MudDataGrid: Fix missing border radius when using FixedHeader Mar 27, 2022
@BenWhite27 BenWhite27 deleted the fix/table-header-border-radius branch April 4, 2022 08:22
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants