Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudOverlay: Await OnClick event #6153

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

BieleckiLtd
Copy link
Contributor

@BieleckiLtd BieleckiLtd commented Jan 16, 2023

Closes #6152

Description

How Has This Been Tested?

unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 91.52% // Head: 91.46% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (2dfa0db) compared to base (73ea3e9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6153      +/-   ##
==========================================
- Coverage   91.52%   91.46%   -0.06%     
==========================================
  Files         383      383              
  Lines       15020    15027       +7     
==========================================
- Hits        13747    13745       -2     
- Misses       1273     1282       +9     
Impacted Files Coverage Δ
src/MudBlazor/Components/Overlay/MudOverlay.razor 100.00% <ø> (ø)
...c/MudBlazor/Components/Overlay/MudOverlay.razor.cs 97.22% <100.00%> (+2.77%) ⬆️
...rc/MudBlazor/Components/Table/MudTFootRow.razor.cs 75.00% <0.00%> (-19.74%) ⬇️
src/MudBlazor/Components/Table/MudTr.razor.cs 84.84% <0.00%> (-9.10%) ⬇️
src/MudBlazor/Components/Table/MudTable.razor.cs 85.64% <0.00%> (-0.30%) ⬇️
src/MudBlazor/Components/Table/TableContext.cs 98.76% <0.00%> (ø)
.../MudBlazor/Components/Table/MudTableGroupRow.razor 100.00% <0.00%> (ø)
...dBlazor/Components/Table/MudTableGroupRow.razor.cs 92.50% <0.00%> (+0.19%) ⬆️
...rc/MudBlazor/Components/Table/MudTHeadRow.razor.cs 95.00% <0.00%> (+0.26%) ⬆️
src/MudBlazor/Components/Table/MudTable.razor 97.10% <0.00%> (+0.28%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro ScarletKuro requested a review from henon April 12, 2023 21:14
@henon henon merged commit 8e393ca into MudBlazor:dev Apr 14, 2023
@henon henon changed the title MudOverlay: Await OnClick event; add missing unit tests MudOverlay: Await OnClick event Apr 14, 2023
@henon
Copy link
Collaborator

henon commented Apr 14, 2023

Thanks!

ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudOverlay: OnClick event is not being awaited
2 participants