Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDateRangePicker: Add missing properties: PlaceholderStart/End and SeparatorIcon #6431

Merged

Conversation

gaplin
Copy link
Contributor

@gaplin gaplin commented Mar 5, 2023

Description

Fixes: #5324
Added PlaceholderStart, PlaceholderEnd and SeparatorIcon properties to MudDateRangePicker.

This properties are used by MudRangeInput so even without this change it is possible to set them.
For example this code works just fine: https://try.mudblazor.com/snippet/wEQnEnkJxCIfABKW

But they were not present on the API docs and are not visible to user (I mean as autocompletion in IDE).
You could only deduce that they are present by looking into RangeInput source code).

How Has This Been Tested?

unit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 5, 2023
@gaplin gaplin closed this Mar 13, 2023
@gaplin gaplin deleted the bug/MudDateRangePicker-missing-properties branch March 13, 2023 20:15
@gaplin gaplin restored the bug/MudDateRangePicker-missing-properties branch March 13, 2023 20:16
@gaplin gaplin reopened this Mar 13, 2023
@gaplin gaplin force-pushed the bug/MudDateRangePicker-missing-properties branch from a6b15c7 to b72fe5b Compare April 6, 2023 20:06
@gaplin gaplin force-pushed the bug/MudDateRangePicker-missing-properties branch from b72fe5b to 7f03efb Compare May 22, 2023 15:42
@gaplin gaplin force-pushed the bug/MudDateRangePicker-missing-properties branch from 7f03efb to ea7d558 Compare June 30, 2023 20:43
@ScarletKuro
Copy link
Member

@henon I think we should merge this

I just found our that our usage example

<MudDateRangePicker Label="Placeholder" @bind-DateRange="_dateRange" PlaceholderStart="Start Date" PlaceholderEnd="End Date" />

sets the PlaceholderStart/End, but IDE shows them they are missing, I don't know why the compiler doesn't give an error.

@ScarletKuro ScarletKuro requested a review from henon March 27, 2024 21:28
@henon
Copy link
Collaborator

henon commented Mar 28, 2024

It doesn't give an error because they are then treated as normal html arguments

@henon henon merged commit 916697a into MudBlazor:dev Mar 28, 2024
3 checks passed
@henon
Copy link
Collaborator

henon commented Mar 28, 2024

Thanks @gaplin and sorry that your PR was overlooked for almost a year

@gaplin gaplin deleted the bug/MudDateRangePicker-missing-properties branch March 28, 2024 09:39
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateRangePicker Placeholder
3 participants