Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: Fix top margin CSS #6483

Merged
merged 1 commit into from
Jul 20, 2023
Merged

FileUpload: Fix top margin CSS #6483

merged 1 commit into from
Jul 20, 2023

Conversation

Mr-Technician
Copy link
Member

@Mr-Technician Mr-Technician commented Mar 17, 2023 •
edited

Description

Fixes #6480's the margin issue by removing the top margin.

image

How Has This Been Tested?

Visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 17, 2023
@ScarletKuro
Copy link
Member

Why does it have label "breaking change", but the type of changes says the opposite?
Can we merged this or not?

@Mr-Technician
Copy link
Member Author

@ScarletKuro it's because it might break layouts due to the CSS change. I will update the text to reflect this.

@dennisrahmen
Copy link
Contributor

@ScarletKuro as I seen you checking other changes for v7, this should also be included/looked at.

@henon henon added the v7 New major MudBlazor version label Jul 20, 2023
@henon henon changed the base branch from dev to v7 July 20, 2023 19:44
@henon henon merged commit 7ffbbf8 into MudBlazor:v7 Jul 20, 2023
@henon
Copy link
Collaborator

henon commented Jul 20, 2023

Merged into v7. People upgrading from v6 might experience layout breaks.

@Mr-Technician Mr-Technician deleted the fix/file-upload-button branch July 20, 2023 23:11
ScarletKuro pushed a commit that referenced this pull request Aug 19, 2023
@Mr-Technician @ScarletKuro
FileUpload: Fix top margin CSS (#6483)
9aa6d2e
@ScarletKuro ScarletKuro mentioned this pull request Mar 23, 2024
Closed
6 tasks
danielchalmers added a commit to danielchalmers/MudBlazor that referenced this pull request Mar 24, 2024
@danielchalmers
FileUpload: Fix top margin CSS
a47874c 
This is a resubmit of MudBlazor#6483 with formatting updates from the dev branch included
@danielchalmers danielchalmers mentioned this pull request Mar 24, 2024
Merged
6 tasks
@ScarletKuro ScarletKuro mentioned this pull request Mar 25, 2024
Open
@ScarletKuro
Copy link
Member

Link to migration guide: #8447

@henon henon moved this from TODO to Done in The Big Break: Breaking Changes in v7 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henon henon henon approved these changes

Assignees
No one assigned
Labels
breaking change bug Something does not work as intended/expected v7 New major MudBlazor version
Projects
The Big Break: Breaking Changes in v7
Done in v7
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button in ButtonTemplate of MudFileUpload size issues
4 participants
@Mr-Technician @ScarletKuro @dennisrahmen @henon